Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3319)

Issue 7300088: Turn off per-iteration tile time reporting (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by EricB
Modified:
11 years, 10 months ago
Reviewers:
Leon, robertphillips
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Turn off per-iteration tile time reporting It's overloading the bench graph generator. Committed: https://code.google.com/p/skia/source/detail?r=7691

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M tools/PictureBenchmark.cpp View 1 2 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 6
EricB
11 years, 10 months ago (2013-02-11 16:10:33 UTC) #1
robertphillips
LGTM + request for expanded comment https://codereview.appspot.com/7300088/diff/2001/tools/PictureBenchmark.cpp File tools/PictureBenchmark.cpp (right): https://codereview.appspot.com/7300088/diff/2001/tools/PictureBenchmark.cpp#newcode135 tools/PictureBenchmark.cpp:135: LGTM - but ...
11 years, 10 months ago (2013-02-11 16:25:53 UTC) #2
Leon
Is longRunningTimer working as desired on 10.6? Also, if we use longRunningTimer, it should be ...
11 years, 10 months ago (2013-02-11 16:28:06 UTC) #3
robertphillips
Leon is right we need to flip which timer gets the gpu timer.
11 years, 10 months ago (2013-02-11 16:31:42 UTC) #4
EricB
Patch set 3: set longRunningTimer to use GL timer. https://codereview.appspot.com/7300088/diff/2001/tools/PictureBenchmark.cpp File tools/PictureBenchmark.cpp (right): https://codereview.appspot.com/7300088/diff/2001/tools/PictureBenchmark.cpp#newcode135 tools/PictureBenchmark.cpp:135: ...
11 years, 10 months ago (2013-02-11 17:59:02 UTC) #5
Leon
11 years, 10 months ago (2013-02-11 18:14:26 UTC) #6
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b