Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5286)

Issue 7299059: Fix a perf regression introduced by r7594: when computing a texture cache key, use the resolved (T… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by Stephen White
Modified:
11 years, 9 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Fix a perf regression introduced by r7594: when computing a texture cache key, use the resolved (Top or Bottom) surface origin, never Default, otherwise we never get a cache hit. Covered by polygon, path benches. See also: https://code.google.com/p/chromium/issues/detail?id=174749. Committed: https://code.google.com/p/skia/source/detail?r=7635

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M src/gpu/GrTexture.cpp View 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 4
Stephen White
PTAL
11 years, 9 months ago (2013-02-07 00:30:46 UTC) #1
robertphillips
lgtm - the new function should probably made static or placed in anonymous name space
11 years, 9 months ago (2013-02-07 00:33:19 UTC) #2
Stephen White
On 2013/02/07 00:33:19, robertphillips wrote: > lgtm - the new function should probably made static ...
11 years, 9 months ago (2013-02-07 00:34:34 UTC) #3
robertphillips
11 years, 9 months ago (2013-02-07 00:36:49 UTC) #4
Message was sent while issue was closed.
On 2013/02/07 00:34:34, Stephen White wrote:
> On 2013/02/07 00:33:19, robertphillips wrote:
> > lgtm - the new function should probably made static or placed in anonymous
> name
> > space
> 
> It's already in namespace {}

doh - missed that
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b