Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(810)

Issue 72980044: Issue 1685 : instructorCourseView: add 'comment' link to each student

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by KaranKamath26
Modified:
10 years, 6 months ago
Reviewers:
damith, jamesdjuhartono
Visibility:
Public.

Description

Issue 1685 : instructorCourseView: add 'comment' link to each student

Patch Set 1 #

Total comments: 1

Patch Set 2 : Issue 1685 : instructorCourseView: add 'comment' link to each student #

Patch Set 3 : Issue 1685 : instructorCourseView: add 'comment' link to each student #

Patch Set 4 : Issue 1685 : instructorCourseView: add 'comment' link to each student #

Total comments: 2

Patch Set 5 : Issue 1685 : instructorCourseView: add 'comment' link to each student #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -5 lines) Patch
M src/main/java/teammates/common/util/Const.java View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/main/java/teammates/ui/controller/InstructorCourseDetailsPageData.java View 1 1 chunk +11 lines, -0 lines 0 comments Download
M src/main/java/teammates/ui/controller/InstructorStudentRecordsPageAction.java View 1 2 chunks +3 lines, -0 lines 0 comments Download
M src/main/java/teammates/ui/controller/InstructorStudentRecordsPageData.java View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/main/webapp/js/instructorStudentRecords.js View 1 3 chunks +9 lines, -2 lines 0 comments Download
M src/main/webapp/jsp/instructorCourseDetails.jsp View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M src/main/webapp/jsp/instructorStudentRecords.jsp View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M src/test/java/teammates/test/cases/ui/browsertests/InstructorCourseDetailsPageUiTest.java View 1 2 3 3 chunks +10 lines, -0 lines 0 comments Download
M src/test/java/teammates/test/cases/ui/browsertests/InstructorStudentListPageUiTest.java View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/test/java/teammates/test/pageobjects/InstructorCourseDetailsPage.java View 1 3 chunks +13 lines, -0 lines 0 comments Download
M src/test/java/teammates/test/pageobjects/InstructorStudentRecordsPage.java View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M src/test/resources/pages/InstructorCourseDetailsPage.html View 1 2 3 4 4 chunks +8 lines, -0 lines 1 comment Download
M src/test/resources/pages/instructorCourseDetailsAddInstructor.html View 1 2 3 4 chunks +8 lines, -0 lines 0 comments Download
M src/test/resources/pages/instructorCourseDetailsStudentDeleteSuccessful.html View 1 2 3 3 chunks +6 lines, -0 lines 0 comments Download
M src/test/resources/pages/instructorStudentListDeleteSuccessful.html View 1 chunk +3 lines, -0 lines 0 comments Download
M src/test/resources/pages/instructorStudentRecordsPage.html View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/test/resources/pages/instructorStudentRecordsPageMixedQuestionType.html View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/test/resources/pages/instructorStudentRecordsPageNoRecords.html View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/test/resources/pages/instructorStudentRecordsPageWithPrivateFeedback.html View 1 2 3 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 3
damith
https://codereview.appspot.com/72980044/diff/1/src/main/webapp/js/instructorStudentRecords.js File src/main/webapp/js/instructorStudentRecords.js (right): https://codereview.appspot.com/72980044/diff/1/src/main/webapp/js/instructorStudentRecords.js#newcode37 src/main/webapp/js/instructorStudentRecords.js:37: { '{' should be in the previous line.
10 years, 6 months ago (2014-03-09 12:41:19 UTC) #1
jamesdjuhartono
https://codereview.appspot.com/72980044/diff/50001/src/test/resources/pages/InstructorCourseDetailsPage.html File src/test/resources/pages/InstructorCourseDetailsPage.html (right): https://codereview.appspot.com/72980044/diff/50001/src/test/resources/pages/InstructorCourseDetailsPage.html#newcode131 src/test/resources/pages/InstructorCourseDetailsPage.html:131: Add Comment</a> Change the studentemail param to be {$test.student1}%40gmail.com, ...
10 years, 6 months ago (2014-03-20 13:37:34 UTC) #2
damith
10 years, 6 months ago (2014-03-24 11:48:11 UTC) #3
https://codereview.appspot.com/72980044/diff/70001/src/test/resources/pages/I...
File src/test/resources/pages/InstructorCourseDetailsPage.html (left):

https://codereview.appspot.com/72980044/diff/70001/src/test/resources/pages/I...
src/test/resources/pages/InstructorCourseDetailsPage.html:128: <a
onmouseout="hideddrivetip()" onmouseover="ddrivetip('Delete the student and the
corresponding evaluations from the course')" onclick="return
toggleDeleteStudentConfirmation('Alice Betsy')"
href="/page/instructorCourseStudentDelete?courseid=CCDetailsUiT.CS2104&amp;studentemail={$test.student1}%40gmail.com&amp;user=CCDetailsUiT.instr"
class="color_black t_student_delete0">
Karan, Note the {$test.student1} above. This is a placeholder for our test
script to inject the test account ID, based on the test.properties file. If not,
the test will fail when the test account id is changed by a developer (each
developer uses a different account).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b