Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(814)

Issue 7294049: Improved compartmentalization of filter tool's optimizations (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by robertphillips
Modified:
11 years, 7 months ago
Reviewers:
DerekS
CC:
skia-review_googlegroups.com, reed1
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Improved compartmentalization of filter tool's optimizations and added additional optimization. Here are the stats on the optimization distribution: Executing desk_espn.skp 1: 1 Executing desk_gmailthread.skp 0: 13 1: 1 Executing desk_googleplus.skp 1: 8 Executing desk_googlespreadsheet.skp 1: 16 Executing desk_googlespreadsheetdashed.skp 1: 16 Executing desk_gws.skp 0: 2 Executing desk_sfgate.skp 0: 3 Executing desk_twitter.skp 1: 3 Executing desk_wowwiki.skp 0: 3 1: 3 Executing desk_yahoosports.skp 1: 1 Executing desk_youtube.skp 1: 1 Executing tabl_culturalsolutions.skp 0: 1 1: 1 Executing tabl_engadget.skp 1: 5 Executing tabl_googlecalendar.skp 0: 4 Executing tabl_hsfi.skp 0: 3 Executing tabl_onlinewsj.skp 0: 12 Executing tabl_theverge.skp 1: 1 Executing tabl_ukwsj.skp 0: 12 totals 0: 53 1: 57 Here are the performance changes (old is on left, new is on right - I ran the gpu numbers twice to factor out noise): * desk_yahooanswers.skp gpu c 43.26 44.22 -0.96 -2.2% * desk_googleplus.skp gpu c 247.28 251.05 -3.77 -1.5% * tabl_hsfi.skp gpu c 101.74 102.48 -0.74 -0.7% * desk_wowwiki.skp gpu c 203.08 203.58 -0.50 -0.2% * desk_espn.skp gpu c 17.25 17.26 -0.01 -0.1% * desk_sfgate.skp gpu c 42.40 42.37 +0.03 +0.1% * desk_gws.skp gpu c 11.02 11.01 +0.01 +0.1% * tabl_googlecalendar.skp gpu c 40.43 40.37 +0.06 +0.1% * desk_twitter.skp gpu c 168.40 168.14 +0.26 +0.2% * tabl_culturalsolutions.skp gpu c 69.56 69.00 +0.56 +0.8% * tabl_theverge.skp gpu c 251.82 247.70 +4.12 +1.6% * desk_gmailthread.skp gpu c 27.97 27.49 +0.48 +1.7% * desk_youtube.skp gpu c 47.80 46.63 +1.17 +2.4% * tabl_engadget.skp gpu c 174.55 169.60 +4.95 +2.8% * tabl_ukwsj.skp gpu c 64.11 60.03 +4.08 +6.4% * tabl_onlinewsj.skp gpu c 71.81 67.20 +4.61 +6.4% *desk_googlespreadsheetdashed.skp gpu c 82.15 73.98 +8.17 +9.9% * desk_googlespreadsheet.skp gpu c 26.02 19.87 +6.15 +23.6% * tabl_theverge.skp gpu c 246.93 252.33 -5.40 -2.2% * desk_twitter.skp gpu c 166.99 169.90 -2.91 -1.7% * desk_yahoosports.skp gpu c 71.82 72.48 -0.66 -0.9% * tabl_googlecalendar.skp gpu c 40.14 40.41 -0.27 -0.7% * tabl_engadget.skp gpu c 166.92 167.44 -0.52 -0.3% * desk_youtube.skp gpu c 45.85 45.99 -0.14 -0.3% * desk_gws.skp gpu c 10.95 10.96 -0.01 -0.1% * tabl_hsfi.skp gpu c 100.98 100.97 +0.01 +0.0% * tabl_culturalsolutions.skp gpu c 68.69 68.19 +0.50 +0.7% * desk_googleplus.skp gpu c 254.95 251.53 +3.42 +1.3% * desk_wowwiki.skp gpu c 204.17 200.87 +3.30 +1.6% * desk_sfgate.skp gpu c 42.67 41.24 +1.43 +3.4% * desk_espn.skp gpu c 17.53 16.88 +0.65 +3.7% * desk_gmailthread.skp gpu c 28.82 27.74 +1.08 +3.7% * tabl_ukwsj.skp gpu c 63.75 60.22 +3.53 +5.5% * tabl_onlinewsj.skp gpu c 71.41 67.01 +4.40 +6.2% *desk_googlespreadsheetdashed.skp gpu c 81.94 73.99 +7.95 +9.7% * desk_googlespreadsheet.skp gpu c 26.39 19.94 +6.45 +24.4% * desk_gws.skp c 4.63 4.72 -0.09 -1.9% * tabl_ukwsj.skp c 31.19 31.43 -0.24 -0.8% * desk_sfgate.skp c 22.59 22.75 -0.16 -0.7% * tabl_theverge.skp c 180.74 180.57 +0.17 +0.1% * tabl_hsfi.skp c 75.61 75.52 +0.09 +0.1% * desk_wowwiki.skp c 176.78 176.41 +0.37 +0.2% * tabl_googlecalendar.skp c 4.21 4.20 +0.01 +0.2% * desk_yahoosports.skp c 30.95 30.86 +0.09 +0.3% * tabl_engadget.skp c 94.71 94.34 +0.37 +0.4% * desk_twitter.skp c 60.72 60.25 +0.47 +0.8% * desk_googleplus.skp c 57.64 57.13 +0.51 +0.9% * desk_youtube.skp c 13.50 13.38 +0.12 +0.9% * desk_gmailthread.skp c 4.48 4.44 +0.04 +0.9% * tabl_culturalsolutions.skp c 65.57 64.77 +0.80 +1.2% * tabl_onlinewsj.skp c 35.23 34.73 +0.50 +1.4% * desk_espn.skp c 15.46 15.14 +0.32 +2.1% *desk_googlespreadsheetdashed.skp c 18.93 17.40 +1.53 +8.1% * desk_googlespreadsheet.skp c 5.77 4.62 +1.15 +19.9% As one would expect only the desk_gmailthread, tabl_ukwsj, tabl_onlinewsj, desk_googlespreadsheetdashed and desk_googlespreadsheet skps show consistent wins. The cpu isn't impacted all that much although the gpu does show some real improvments.

Patch Set 1 #

Patch Set 2 : Minor changes #

Patch Set 3 : more minor changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -31 lines) Patch
M tools/filtermain.cpp View 1 2 4 chunks +156 lines, -31 lines 0 comments Download

Messages

Total messages: 3
robertphillips
11 years, 7 months ago (2013-02-05 20:39:18 UTC) #1
DerekS
lgtm
11 years, 7 months ago (2013-02-05 20:43:09 UTC) #2
robertphillips
11 years, 7 months ago (2013-02-05 20:52:11 UTC) #3
Message was sent while issue was closed.
committed as r7601
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b