Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(883)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 72860043: Issue 1686: instructorStudentList: omit archived courses by default

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by Gigikie
Modified:
10 years, 6 months ago
Reviewers:
jamesdjuhartono
Visibility:
Public.

Description

Issue 1686: instructorStudentList: omit archived courses by default

Patch Set 1 #

Patch Set 2 : keep updated #

Total comments: 1

Patch Set 3 : update action test and ui test #

Total comments: 2

Patch Set 4 : update version #

Patch Set 5 : merge with default #

Unified diffs Side-by-side diffs Delta from patch set Stats (+652 lines, -15 lines) Patch
M src/main/java/teammates/common/util/Const.java View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/main/java/teammates/ui/controller/InstructorStudentListPageAction.java View 2 chunks +2 lines, -0 lines 0 comments Download
M src/main/java/teammates/ui/controller/InstructorStudentListPageData.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/main/webapp/js/instructorStudentList.js View 2 chunks +44 lines, -0 lines 0 comments Download
M src/main/webapp/jsp/instructorStudentList.jsp View 6 chunks +17 lines, -13 lines 0 comments Download
M src/main/webapp/stylesheets/instructorStudentList.css View 1 chunk +4 lines, -0 lines 0 comments Download
M src/test/java/teammates/test/cases/ui/InstructorStudentListPageActionTest.java View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M src/test/java/teammates/test/cases/ui/browsertests/InstructorStudentListPageUiTest.java View 1 2 2 chunks +23 lines, -0 lines 0 comments Download
M src/test/java/teammates/test/pageobjects/InstructorStudentListPage.java View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M src/test/resources/data/InstructorStudentListPageUiTest.json View 1 2 4 chunks +27 lines, -1 line 0 comments Download
M src/test/resources/pages/instructorHomeSearchStudent.html View 1 chunk +4 lines, -0 lines 0 comments Download
M src/test/resources/pages/instructorStudentListPage.html View 1 chunk +4 lines, -0 lines 0 comments Download
A src/test/resources/pages/instructorStudentListPageDisplayArchivedCourses.html View 1 2 3 1 chunk +272 lines, -0 lines 0 comments Download
A src/test/resources/pages/instructorStudentListPageHideArchivedCourses.html View 1 2 3 1 chunk +218 lines, -0 lines 0 comments Download
M src/test/resources/pages/instructorStudentListPageLiveSearch.html View 1 chunk +4 lines, -0 lines 0 comments Download
M src/test/resources/pages/instructorStudentListPageNoCourse.html View 1 chunk +5 lines, -0 lines 0 comments Download
M src/test/resources/pages/instructorStudentListPageNoStudent.html View 1 chunk +4 lines, -0 lines 0 comments Download
M src/test/resources/pages/instructorStudentListPageSearchNoMatch.html View 1 chunk +4 lines, -0 lines 0 comments Download
M src/test/resources/pages/instructorStudentListPageSearchShowEmail.html View 1 chunk +4 lines, -0 lines 0 comments Download
M src/test/resources/pages/instructorStudentListPageSearchStudent.html View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2
jamesdjuhartono
https://codereview.appspot.com/72860043/diff/20001/src/main/java/teammates/ui/controller/InstructorStudentListPageAction.java File src/main/java/teammates/ui/controller/InstructorStudentListPageAction.java (right): https://codereview.appspot.com/72860043/diff/20001/src/main/java/teammates/ui/controller/InstructorStudentListPageAction.java#newcode26 src/main/java/teammates/ui/controller/InstructorStudentListPageAction.java:26: HashMap<String, CourseDetailsBundle> courses = logic.getCourseDetailsListForInstructor(account.googleId); This here means that ...
10 years, 6 months ago (2014-03-09 11:57:27 UTC) #1
jamesdjuhartono
10 years, 6 months ago (2014-03-11 14:43:01 UTC) #2 
https://codereview.appspot.com/72860043/diff/40001/src/test/resources/pages/i...
File
src/test/resources/pages/instructorStudentListPageDisplayArchivedCourses.html
(right):

https://codereview.appspot.com/72860043/diff/40001/src/test/resources/pages/i...
src/test/resources/pages/instructorStudentListPageDisplayArchivedCourses.html:253:
V4.18]
Please update this value. Use V{$version} to replace the version

https://codereview.appspot.com/72860043/diff/40001/src/test/resources/pages/i...
File src/test/resources/pages/instructorStudentListPageHideArchivedCourses.html
(right):

https://codereview.appspot.com/72860043/diff/40001/src/test/resources/pages/i...
src/test/resources/pages/instructorStudentListPageHideArchivedCourses.html:199:
V4.18]
Update here too
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b