Issue 7281046: Make GPU unit tests use GrContexts of different GL types.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7281046: Make GPU unit tests use GrContexts of different GL types. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by bsalomon

Modified:
11 years, 11 months ago

Reviewers:
Stephen White

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Make GPU unit tests use GrContexts of different GL types. Committed: https://code.google.com/p/skia/source/detail?r=7540

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+440 lines, -344 lines)			Patch
M	include/gpu/GrContextFactory.h	View	1	1 chunk	+20 lines, -2 lines	0 comments	Download
M	tests/ClipCacheTest.cpp	View		2 chunks	+14 lines, -3 lines	0 comments	Download
M	tests/GLProgramsTest.cpp	View		2 chunks	+9 lines, -3 lines	0 comments	Download
M	tests/GpuBitmapCopyTest.cpp	View		2 chunks	+87 lines, -68 lines	0 comments	Download
M	tests/HashCacheTest.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/PremulAlphaRoundTripTest.cpp	View		2 chunks	+62 lines, -47 lines	0 comments	Download
M	tests/ReadPixelsTest.cpp	View		3 chunks	+87 lines, -76 lines	0 comments	Download
M	tests/ReadWriteAlphaTest.cpp	View		1 chunk	+65 lines, -59 lines	0 comments	Download
M	tests/Test.h	View		2 chunks	+4 lines, -9 lines	0 comments	Download
M	tests/Test.cpp	View		1 chunk	+8 lines, -21 lines	0 comments	Download
M	tests/TestClassDef.h	View		1 chunk	+22 lines, -24 lines	0 comments	Download
M	tests/WritePixelsTest.cpp	View		3 chunks	+59 lines, -29 lines	0 comments	Download
M	tests/skia_test.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2

Stephen White

11 years, 11 months ago (2013-02-04 16:10:38 UTC) #2

Rietveld didn't do a very good job of diffing here, but if the tests are happy,
I'm happy.

LGTM.