Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(536)

Issue 7278049: code review 7278049: time: add Location.Parse (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 4 months ago by bradfitz
Modified:
6 years, 4 months ago
Reviewers:
adg, rsc, golang-dev
Visibility:
Public.

Description

time: add Location.Parse Fixes issue 3653

Patch Set 1 #

Patch Set 2 : diff -r ada7873ff329 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r ada7873ff329 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r ada7873ff329 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -5 lines) Patch
M src/pkg/time/format.go View 1 3 chunks +10 lines, -5 lines 0 comments Download
M src/pkg/time/time_test.go View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 7
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
6 years, 4 months ago (2013-02-03 21:58:16 UTC) #1
rsc
Can it be func ParseInLocation instead? Location is required for using the time package, but ...
6 years, 4 months ago (2013-02-04 00:37:10 UTC) #2
rsc
Actually, I think the differences are a little more subtle. I'll include the function in ...
6 years, 4 months ago (2013-02-04 00:45:59 UTC) #3
adg
On 4 February 2013 11:37, Russ Cox <rsc@golang.org> wrote: > Can it be func ParseInLocation ...
6 years, 4 months ago (2013-02-04 00:58:26 UTC) #4
rsc
I mean that if you have a time.Time in your program, then by necessity you ...
6 years, 4 months ago (2013-02-04 01:06:48 UTC) #5
adg
On 4 February 2013 12:06, Russ Cox <rsc@golang.org> wrote: > If we make Parse a ...
6 years, 4 months ago (2013-02-04 01:11:48 UTC) #6
bradfitz
6 years, 4 months ago (2013-02-04 04:57:25 UTC) #7
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b