Issue 7277055: Nuke SkSingleInputImageFilter. 99% of its functionality was refactored into SkImageFilterUtils, so…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7277055: Nuke SkSingleInputImageFilter. 99% of its functionality was refactored into SkImageFilterUtils, so… (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by Stephen White

Modified:
11 years, 9 months ago

Reviewers:
bsalomon, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Nuke SkSingleInputImageFilter. 99% of its functionality was refactored into SkImageFilterUtils in https://code.google.com/p/skia/source/detail?r=7467, so it has outlived its usefulness. Committed: https://code.google.com/p/skia/source/detail?r=7563

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -100 lines)			Patch
M	gyp/effects.gypi	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	include/effects/SkBicubicImageFilter.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	include/effects/SkBlurImageFilter.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	include/effects/SkColorFilterImageFilter.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	include/effects/SkLightingImageFilter.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	include/effects/SkMatrixConvolutionImageFilter.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	include/effects/SkMorphologyImageFilter.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	include/effects/SkOffsetImageFilter.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
D	include/effects/SkSingleInputImageFilter.h	View	1 chunk	+0 lines, -37 lines	0 comments	Download
M	src/effects/SkBicubicImageFilter.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/effects/SkBlurImageFilter.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/effects/SkColorFilterImageFilter.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/effects/SkMatrixConvolutionImageFilter.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/effects/SkMorphologyImageFilter.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/effects/SkOffsetImageFilter.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
D	src/effects/SkSingleInputImageFilter.cpp	View	1 chunk	+0 lines, -32 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

11 years, 9 months ago (2013-02-04 22:42:56 UTC) #3

lgtm


On Mon, Feb 4, 2013 at 5:36 PM, <reed@google.com> wrote:

> always in favor of deleting code : lgtm
>
>
https://codereview.appspot.**com/7277055/<https://codereview.appspot.com/7277...
>

Expand All Messages | Collapse All Messages