Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(388)

Issue 7277055: Nuke SkSingleInputImageFilter. 99% of its functionality was refactored into SkImageFilterUtils, so… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by Stephen White
Modified:
11 years, 1 month ago
Reviewers:
bsalomon, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Nuke SkSingleInputImageFilter. 99% of its functionality was refactored into SkImageFilterUtils in https://code.google.com/p/skia/source/detail?r=7467, so it has outlived its usefulness. Committed: https://code.google.com/p/skia/source/detail?r=7563

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -100 lines) Patch
M gyp/effects.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M include/effects/SkBicubicImageFilter.h View 3 chunks +3 lines, -3 lines 0 comments Download
M include/effects/SkBlurImageFilter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M include/effects/SkColorFilterImageFilter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M include/effects/SkLightingImageFilter.h View 3 chunks +3 lines, -3 lines 0 comments Download
M include/effects/SkMatrixConvolutionImageFilter.h View 3 chunks +3 lines, -3 lines 0 comments Download
M include/effects/SkMorphologyImageFilter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M include/effects/SkOffsetImageFilter.h View 2 chunks +3 lines, -3 lines 0 comments Download
D include/effects/SkSingleInputImageFilter.h View 1 chunk +0 lines, -37 lines 0 comments Download
M src/effects/SkBicubicImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkBlurImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkColorFilterImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMatrixConvolutionImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkOffsetImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
D src/effects/SkSingleInputImageFilter.cpp View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 3
Stephen White
PTAL. Pretty simple.
11 years, 1 month ago (2013-02-04 22:27:20 UTC) #1
reed1
always in favor of deleting code : lgtm
11 years, 1 month ago (2013-02-04 22:36:53 UTC) #2
bsalomon
11 years, 1 month ago (2013-02-04 22:42:56 UTC) #3
lgtm


On Mon, Feb 4, 2013 at 5:36 PM, <reed@google.com> wrote:

> always in favor of deleting code : lgtm
>
>
https://codereview.appspot.**com/7277055/<https://codereview.appspot.com/7277...
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b