Issue 7267043: Add overdraw visualization to the debugger

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7267043: Add overdraw visualization to the debugger (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by robertphillips

Modified:
11 years, 4 months ago

Reviewers:
DerekS

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add overdraw visualization to the debugger

Patch Set 2 : Updated color ramp #

Patch Set 3 : Moved overdrawViz flag into DebugCanvas #

Total comments: 2

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+115 lines, -2 lines)			Patch
M	debugger/QT/SkDebuggerGUI.h	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	debugger/QT/SkDebuggerGUI.cpp	View	1 2	2 chunks	+6 lines, -0 lines	0 comments	Download
M	debugger/QT/SkRasterWidget.cpp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	debugger/QT/SkSettingsWidget.h	View	1 2	2 chunks	+8 lines, -0 lines	0 comments	Download
M	debugger/QT/SkSettingsWidget.cpp	View	1 2	2 chunks	+8 lines, -0 lines	0 comments	Download
M	debugger/SkDebugCanvas.h	View	1 2	2 chunks	+8 lines, -1 line	0 comments	Download
M	debugger/SkDebugCanvas.cpp	View	1 2	5 chunks	+72 lines, -1 line	2 comments	Download
M	debugger/SkDebugger.h	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

DerekS

On 2013/02/01 18:31:20, robertphillips wrote: Any luck with have the shader be a no-op on ...

11 years, 4 months ago (2013-02-05 20:37:26 UTC) #2

DerekS

lgtm with one style nit. https://codereview.appspot.com/7267043/diff/9001/debugger/SkDebugCanvas.cpp File debugger/SkDebugCanvas.cpp (right): https://codereview.appspot.com/7267043/diff/9001/debugger/SkDebugCanvas.cpp#newcode97 debugger/SkDebugCanvas.cpp:97: static const SkPMColor table[] ...

11 years, 4 months ago (2013-02-05 21:07:42 UTC) #4

robertphillips

11 years, 4 months ago (2013-02-06 20:14:11 UTC) #5

Message was sent while issue was closed.

committed as r7627

https://codereview.appspot.com/7267043/diff/9001/debugger/SkDebugCanvas.cpp
File debugger/SkDebugCanvas.cpp (right):

https://codereview.appspot.com/7267043/diff/9001/debugger/SkDebugCanvas.cpp#n...
debugger/SkDebugCanvas.cpp:97: static const SkPMColor table[] = {
On 2013/02/05 21:07:42, DerekS wrote:
> can we move this into the proc so that we don't have the variable in scope for
> other functions in this file? or at least call it gTable.

Done.

Expand All Messages | Collapse All Messages