Issue 72640046: Issue 1248: instructorEvalResultDownload: commas in the student name mess up the downloaded csv file

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 72640046: Issue 1248: instructorEvalResultDownload: commas in the student name mess up the downloaded csv file

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by Gigikie

Modified:
10 years, 8 months ago

Reviewers:
arnold.koroa

Visibility:
Public.

More Reviews

Description

Issue 1248: instructorEvalResultDownload: commas in the student name mess up the downloaded csv file

Patch Set 1 #

Patch Set 2 : keep updated with default branch #

Total comments: 1

Patch Set 3 : update testing document #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -20 lines)			Patch
	M	src/main/java/teammates/logic/core/EvaluationsLogic.java	View		3 chunks	+9 lines, -4 lines	0 comments	Download
	M	src/test/java/teammates/test/cases/logic/LogicTest.java	View	1 2	1 chunk	+16 lines, -16 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

arnold.koroa

10 years, 8 months ago (2014-03-10 03:32:29 UTC) #1

https://codereview.appspot.com/72640046/diff/20001/src/test/java/teammates/te...
File src/test/java/teammates/test/cases/logic/LogicTest.java (right):

https://codereview.appspot.com/72640046/diff/20001/src/test/java/teammates/te...
src/test/java/teammates/test/cases/logic/LogicTest.java:2288: //Team
1.2,,student5 In Course1,,-999,,-9999,,
Do update this comment documentation too

Expand All Messages | Collapse All Messages