Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(262)

Issue 7261: * Allow for nested contexts of any depth. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by Neil Puttock
Modified:
9 years, 11 months ago
Reviewers:
hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

* Allow for nested contexts of any depth. - use a set to keep track of visited contexts - remove InnerChoirStaff and InnerStaffGroup

Patch Set 1 #

Patch Set 2 : Use wrapper function for set. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -41 lines) Patch
M Documentation/topdocs/NEWS.tely View 3 chunks +22 lines, -9 lines 0 comments Download
A input/regression/context-nested-staffgroup.ly View 1 chunk +15 lines, -0 lines 0 comments Download
M lily/context-def.cc View 1 2 chunks +28 lines, -7 lines 0 comments Download
M lily/include/context-def.hh View 1 2 chunks +7 lines, -1 line 0 comments Download
M ly/engraver-init.ly View 4 chunks +7 lines, -23 lines 0 comments Download
M python/convertrules.py View 1 chunk +17 lines, -1 line 0 comments Download

Messages

Total messages: 3
hanwenn
http://codereview.appspot.com/7261/diff/1/2 File lily/context-def.cc (right): http://codereview.appspot.com/7261/diff/1/2#newcode215 Line 215: seen = new set<const Context_def *> (); Can ...
10 years, 8 months ago (2008-10-08 03:40:33 UTC) #1
Neil Puttock
On 2008/10/08 03:40:33, hanwenn wrote: > http://codereview.appspot.com/7261/diff/1/2 > File lily/context-def.cc (right): > > http://codereview.appspot.com/7261/diff/1/2#newcode215 > ...
10 years, 7 months ago (2008-11-07 23:10:13 UTC) #2
hanwenn
10 years, 7 months ago (2008-11-14 01:43:43 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b