Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(262)

Issue 7254043: restore cache-count for gradients to p.o.2. so we can perform fancier dithering (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by reed1
Modified:
11 years, 10 months ago
Reviewers:
robertphillips, TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/
Visibility:
Public.

Description

restore cache-count for gradients to p.o.2. so we can perform fancier dithering in the future. Committed: https://code.google.com/p/skia/source/detail?r=7506

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -60 lines) Patch
M trunk/src/effects/gradients/SkGradientShader.cpp View 11 chunks +7 lines, -30 lines 0 comments Download
M trunk/src/effects/gradients/SkGradientShaderPriv.h View 2 chunks +2 lines, -15 lines 0 comments Download
M trunk/src/effects/gradients/SkLinearGradient.cpp View 1 3 chunks +14 lines, -12 lines 0 comments Download
M trunk/src/effects/gradients/SkRadialGradient.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4
reed1
Need this cleanup before I can land my 2x2 dither stuff. Does not appear to ...
11 years, 10 months ago (2013-01-31 22:07:58 UTC) #1
robertphillips
lgtm
11 years, 10 months ago (2013-02-01 00:26:28 UTC) #2
TomH
When I(?) put this in it was because of interpolation issues at the endpoints, as ...
11 years, 10 months ago (2013-02-01 13:20:53 UTC) #3
reed1
11 years, 10 months ago (2013-02-01 13:44:46 UTC) #4
Message was sent while issue was closed.
On 2013/02/01 13:20:53, TomH wrote:
> When I(?) put this in it was because of interpolation issues at the endpoints,
> as the ex-comment states. Watch closely when you roll to Chrome?

Agreed, that is why I explicitly perform the range-check in the vertical_lerp
code (the only place we seemed to use lerp).

I confirmed that (a) we have GMs that fail if I skip that (new) code, and (b) w/
the new code the GMs pass.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b