Issue 7250043: Do not use dynamic_cast if RTTI is disabled.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7250043: Do not use dynamic_cast if RTTI is disabled. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by apatrick1

Modified:
11 years, 3 months ago

Reviewers:
dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/branches/dx11proto/

Visibility:
Public.

More Reviews

Description

Do not use dynamic_cast if RTTI is disabled. Committed: https://code.google.com/p/angleproject/source/detail?r=1808

Patch Set 1 : #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -20 lines)			Patch
M	src/common/debug.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/libGLESv2/renderer/Image11.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libGLESv2/renderer/Image9.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libGLESv2/renderer/IndexBuffer11.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libGLESv2/renderer/IndexBuffer9.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libGLESv2/renderer/RenderTarget11.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libGLESv2/renderer/RenderTarget9.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libGLESv2/renderer/Renderer11.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libGLESv2/renderer/Renderer9.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libGLESv2/renderer/ShaderExecutable11.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libGLESv2/renderer/ShaderExecutable9.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libGLESv2/renderer/SwapChain11.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libGLESv2/renderer/SwapChain9.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libGLESv2/renderer/TextureStorage11.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/libGLESv2/renderer/TextureStorage9.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/libGLESv2/renderer/VertexBuffer11.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libGLESv2/renderer/VertexBuffer9.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

apatrick1

I could also disable warning C4541 or compile ANGLE with RTTI enabled. The latter would ...

11 years, 3 months ago (2013-01-30 21:32:28 UTC) #1

LGTM

Expand All Messages | Collapse All Messages