Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(139)

Unified Diff: src/core/SkRRect.cpp

Issue 7249043: Start addressing the clang static analyzer issues (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/core/SkRegion.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkRRect.cpp
===================================================================
--- src/core/SkRRect.cpp (revision 7468)
+++ src/core/SkRRect.cpp (working copy)
@@ -36,9 +36,7 @@
fType = kSimple_Type;
if (xRad >= SkScalarHalf(fRect.width()) && yRad >= SkScalarHalf(fRect.height())) {
fType = kOval_Type;
- // TODO: try asserting they are already W/2 & H/2 already
- xRad = SkScalarHalf(fRect.width());
- yRad = SkScalarHalf(fRect.height());
+ // TODO: assert that all the x&y radii are already W/2 & H/2
}
SkDEBUGCODE(this->validate();)
« no previous file with comments | « no previous file | src/core/SkRegion.cpp » ('j') | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b