Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(534)

Issue 72460044: Issue 1674: Display team info in instructorFeedbackResultsBy*.jsp

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by Gigikie
Modified:
10 years, 6 months ago
Reviewers:
arnold.koroa
Visibility:
Public.

Description

Issue 1674: Display team info in instructorFeedbackResultsBy*.jsp

Patch Set 1 #

Patch Set 2 : Issue 1674: Display team info in instructorFeedbackResultsBy*.jsp #

Patch Set 3 : keep updated with default branch #

Total comments: 3

Patch Set 4 : update: minor changes and added some more testing #

Patch Set 5 : update: make dev green #

Patch Set 6 : update: make dev green #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -81 lines) Patch
M src/main/java/teammates/common/datatransfer/FeedbackSessionResultsBundle.java View 5 chunks +26 lines, -0 lines 0 comments Download
M src/main/webapp/jsp/instructorFeedbackResultsByTable.jsp View 1 2 3 1 chunk +13 lines, -4 lines 0 comments Download
M src/main/webapp/jsp/instructorStudentRecords.jsp View 1 2 3 3 chunks +7 lines, -4 lines 0 comments Download
M src/test/java/teammates/test/cases/logic/FeedbackSessionsLogicTest.java View 1 2 3 1 chunk +63 lines, -0 lines 0 comments Download
M src/test/java/teammates/test/cases/ui/browsertests/InstructorFeedbackResultsPageUiTest.java View 1 chunk +4 lines, -4 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackResultsPageOpen.html View 1 2 3 10 chunks +10 lines, -10 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackResultsSortGiver.html View 1 2 3 8 chunks +8 lines, -8 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackResultsSortRecipient.html View 1 2 3 10 chunks +10 lines, -10 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackResultsSortTable.html View 1 2 3 12 chunks +24 lines, -24 lines 0 comments Download
M src/test/resources/pages/instructorStudentRecordsPage.html View 3 chunks +5 lines, -5 lines 0 comments Download
M src/test/resources/pages/instructorStudentRecordsPageMixedQuestionType.html View 1 2 3 4 8 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 1
arnold.koroa
10 years, 6 months ago (2014-03-11 03:12:10 UTC) #1
https://codereview.appspot.com/72460044/diff/40001/src/main/webapp/jsp/instru...
File src/main/webapp/jsp/instructorFeedbackResultsByTable.jsp (right):

https://codereview.appspot.com/72460044/diff/40001/src/main/webapp/jsp/instru...
src/main/webapp/jsp/instructorFeedbackResultsByTable.jsp:81: recipientName =
data.bundle.appendTeamNameToName(recipientName, recipientTeamName);
one indentation too many?

https://codereview.appspot.com/72460044/diff/40001/src/main/webapp/jsp/instru...
File src/main/webapp/jsp/instructorStudentRecords.jsp (right):

https://codereview.appspot.com/72460044/diff/40001/src/main/webapp/jsp/instru...
src/main/webapp/jsp/instructorStudentRecords.jsp:220: giverName = recipientName
= feedback.appendTeamNameToName(data.student.name, data.student.team);
Don't assign things to multiple variables at the same time as it might be missed
during future edits

https://codereview.appspot.com/72460044/diff/40001/src/test/java/teammates/te...
File src/test/java/teammates/test/cases/logic/FeedbackSessionsLogicTest.java
(right):

https://codereview.appspot.com/72460044/diff/40001/src/test/java/teammates/te...
src/test/java/teammates/test/cases/logic/FeedbackSessionsLogicTest.java:630: }
What about when the recipient is None/instructors?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b