Add GrDrawTarget::DrawInfo, combine API for performing indexed/non-indexed draws in subclasses.

Add GrDrawTarget::DrawInfo, combine API for performing indexed/non-indexed draws in subclasses.
Committed: https://code.google.com/p/skia/source/detail?r=7466

[bsalomon, 2013-01-28 20:22:20]

The motivation for this is that GrDrawTarget will do any processing to support
GrEffect dst-reads and then communicate the optional extra texture in this new
class. This will happen before onDraw() is called so that the dst copies are
baked into the GrIODBs commands.

https://codereview.appspot.com/7237045/diff/2001/src/gpu/GrInOrderDrawBuffer.h
File src/gpu/GrInOrderDrawBuffer.h (right):

https://codereview.appspot.com/7237045/diff/2001/src/gpu/GrInOrderDrawBuffer....
src/gpu/GrInOrderDrawBuffer.h:123: // TODO: Make this derive from DrawInfo
I tried to do this in this CL but there is extra complication from the overrides
of drawRect and drawIndexedInstances. They need to be first processes by the
base class and have subclasses override private
onDrawRect/onDrawIndexedInstances functions.

[robertphillips, 2013-01-29 15:19:45]

LGTM + suggestions

https://codereview.appspot.com/7237045/diff/2001/src/gpu/GrInOrderDrawBuffer.cpp
File src/gpu/GrInOrderDrawBuffer.cpp (right):

https://codereview.appspot.com/7237045/diff/2001/src/gpu/GrInOrderDrawBuffer....
src/gpu/GrInOrderDrawBuffer.cpp:378: 
if (!info.vertexCount()) {
    return;
}
?

https://codereview.appspot.com/7237045/diff/2001/src/gpu/GrInOrderDrawBuffer....
src/gpu/GrInOrderDrawBuffer.cpp:836: 
Fuse these two recordDraws into one?

https://codereview.appspot.com/7237045/diff/2001/src/gpu/gl/GrGpuGL.h
File src/gpu/gl/GrGpuGL.h (right):

https://codereview.appspot.com/7237045/diff/2001/src/gpu/gl/GrGpuGL.h#newcode117
src/gpu/gl/GrGpuGL.h:117: // sets up vertex attribute pointers and strides.
explanation of "extraStartIndexOffset"?

https://codereview.appspot.com/7237045/diff/2001/src/gpu/gl/GrGpuGL.h#newcode118
src/gpu/gl/GrGpuGL.h:118: void setupGeometry(const DrawInfo& info, int*
extraStartIndexOffset);
extra extra

[bsalomon, 2013-01-30 16:10:15]

https://codereview.appspot.com/7237045/diff/2001/src/gpu/GrInOrderDrawBuffer.cpp
File src/gpu/GrInOrderDrawBuffer.cpp (right):

https://codereview.appspot.com/7237045/diff/2001/src/gpu/GrInOrderDrawBuffer....
src/gpu/GrInOrderDrawBuffer.cpp:378: 
On 2013/01/29 15:19:45, robertphillips wrote:
> if (!info.vertexCount()) {
>     return;
> }
> ?

I removed the checks b/c GrDrawTarget is already checking the counts before
calling this

https://codereview.appspot.com/7237045/diff/2001/src/gpu/GrInOrderDrawBuffer....
src/gpu/GrInOrderDrawBuffer.cpp:836: 
On 2013/01/29 15:19:45, robertphillips wrote:
> Fuse these two recordDraws into one?

The next CL will eliminate the one that does not take a DrawInfo. DrawRecord
will a subclass of DrawInfo and always initialized from a DrawInfo passed by
GrDrawTarget.

https://codereview.appspot.com/7237045/diff/2001/src/gpu/gl/GrGpuGL.h
File src/gpu/gl/GrGpuGL.h (right):

https://codereview.appspot.com/7237045/diff/2001/src/gpu/gl/GrGpuGL.h#newcode117
src/gpu/gl/GrGpuGL.h:117: // sets up vertex attribute pointers and strides.
On 2013/01/29 15:19:45, robertphillips wrote:
> explanation of "extraStartIndexOffset"?

Done.

    // sets up vertex attribute pointers and strides. startIndexOffset specifies
an additional
    // offset into the index buffer to the first index to be read. It accounts
for the fact that
    // index buffer pool may have provided space in the middle of a larger index
buffer.

Renamed to startIndexOffset.

https://codereview.appspot.com/7237045/diff/2001/src/gpu/gl/GrGpuGL.h#newcode118
src/gpu/gl/GrGpuGL.h:118: void setupGeometry(const DrawInfo& info, int*
extraStartIndexOffset);
On 2013/01/29 15:19:45, robertphillips wrote:
> extra extra

Done.