Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(953)

Delta Between Two Patch Sets: test/fixedbugs/bug357.go

Issue 7235081: code review 7235081: cmd/gc: put 'not used' message on correct line (Closed)
Left Patch Set: diff -r 885321ad3873 https://code.google.com/p/go/ Created 12 years, 1 month ago
Right Patch Set: diff -r e619e8e0f44a https://code.google.com/p/go/ Created 12 years, 1 month ago
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
Right: Side by side diff | Download
« no previous file with change/comment | « src/cmd/gc/y.tab.c ('k') | test/fixedbugs/bug379.go » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
(no file at all)
1 // errorcheck 1 // errorcheck
2 2
3 // Copyright 2011 The Go Authors. All rights reserved. 3 // Copyright 2011 The Go Authors. All rights reserved.
4 // Use of this source code is governed by a BSD-style 4 // Use of this source code is governed by a BSD-style
5 // license that can be found in the LICENSE file. 5 // license that can be found in the LICENSE file.
6 6
7 // issue 1993. 7 // issue 1993.
8 // error used to have last line number in file 8 // error used to have last line number in file
9 9
10 package main 10 package main
11 11
12 func bla1() bool { 12 func bla1() bool {
13 return false 13 return false
14 } 14 }
15 15
16 func bla5() bool { 16 func bla5() bool {
17 _ = 1 17 _ = 1
18 » false // ERROR "false not used|value computed is not used" 18 » false // ERROR "false evaluated but not used|value computed is not used "
19 _ = 2 19 _ = 2
20 return false 20 return false
21 } 21 }
22 22
23 func main() { 23 func main() {
24 x := bla1() 24 x := bla1()
25 _ = x 25 _ = x
26 } 26 }
LEFTRIGHT

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b