Issue 7235051: Move vertex layout definitions from GrDrawTarget to GrDrawState

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7235051: Move vertex layout definitions from GrDrawTarget to GrDrawState (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by JimVV

Modified:
11 years, 10 months ago

Reviewers:
bsalomon, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Move vertex layout definitions from GrDrawTarget to GrDrawState. This is the first step in revising vertex layouts so that the currently installed GrEffects determine the current vertex layout. Eventually GrDrawStage will query or track the current GrEffects and adjust the layout accordingly, so GrDrawStage needs ownership of GrVertexLayout.

Patch Set 1 #

Total comments: 3

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+810 lines, -802 lines)			Patch
M	experimental/AndroidPathRenderer/GrAndroidPathRenderer.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/gpu/GrAAConvexPathRenderer.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrAAHairLinePathRenderer.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/gpu/GrAARectRenderer.cpp	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/gpu/GrBufferAllocPool.cpp	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	src/gpu/GrDrawState.h	View	2 chunks	+265 lines, -1 line	1 comment	Download
M	src/gpu/GrDrawState.cpp	View	2 chunks	+485 lines, -0 lines	1 comment	Download
M	src/gpu/GrDrawTarget.h	View	4 chunks	+0 lines, -259 lines	0 comments	Download
M	src/gpu/GrDrawTarget.cpp	View	9 chunks	+7 lines, -489 lines	1 comment	Download
M	src/gpu/GrGpu.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/gpu/GrInOrderDrawBuffer.cpp	View	8 chunks	+9 lines, -9 lines	0 comments	Download
M	src/gpu/GrTextContext.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGLProgram.cpp	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL_program.cpp	View	10 chunks	+12 lines, -12 lines	0 comments	Download
M	src/gpu/gr_unittests.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/GLProgramsTest.cpp	View	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bsalomon

On 2013/01/28 16:44:57, JimVV wrote: LGTM. I'll be so so happy when we can remove ...

11 years, 10 months ago (2013-01-28 17:08:20 UTC) #2

bsalomon

https://codereview.appspot.com/7235051/diff/1/src/gpu/GrDrawTarget.cpp File src/gpu/GrDrawTarget.cpp (right): https://codereview.appspot.com/7235051/diff/1/src/gpu/GrDrawTarget.cpp#newcode633 src/gpu/GrDrawTarget.cpp:633: &colorOffset, NULL, NULL); nit: can we align the params?

11 years, 10 months ago (2013-01-28 17:08:30 UTC) #3

robertphillips

11 years, 10 months ago (2013-01-28 19:05:54 UTC) #4

LGTM + nits

https://codereview.appspot.com/7235051/diff/1/src/gpu/GrDrawState.cpp
File src/gpu/GrDrawState.cpp (right):

https://codereview.appspot.com/7235051/diff/1/src/gpu/GrDrawState.cpp#newcode55
src/gpu/GrDrawState.cpp:55: * time. When the number of stages or tex coords is
bumped or the way bits
GrDrawState.h

https://codereview.appspot.com/7235051/diff/1/src/gpu/GrDrawState.h
File src/gpu/GrDrawState.h (right):

https://codereview.appspot.com/7235051/diff/1/src/gpu/GrDrawState.h#newcode20
src/gpu/GrDrawState.h:20: 
Why not alphabetical order with SkMatrix.h?

Expand All Messages | Collapse All Messages