Issue 7232062: rename kMultiply_Mode to kModulate_Mode

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7232062: rename kMultiply_Mode to kModulate_Mode (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by reed1

Modified:
11 years, 5 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

clone of https://codereview.appspot.com/7208043/ Committed: https://code.google.com/p/skia/source/detail?r=7476

Patch Set 1 #

Patch Set 2 : #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -23 lines)			Patch
M	gm/blend.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gm/modecolorfilters.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gm/xfermodes.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/core/SkCanvas.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/core/SkXfermode.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/effects/SkBlendImageFilter.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/effects/SkPorterDuff.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	samplecode/SampleColorFilter.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	samplecode/SampleXfermodesBlur.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkDraw.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkXfermode.cpp	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	src/effects/SkBlendImageFilter.cpp	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/effects/SkPorterDuff.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrSWMaskHelper.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pdf/SkPDFGraphicState.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

robertphillips

11 years, 5 months ago (2013-01-31 13:53:12 UTC) #1

Message was sent while issue was closed.

I re-added kMultiply_Mode (as an alias to kModulate_Mode) to both SkXfermode.h
and SkBlendImageFilter.h to get Chrome compiling. It appears Chrome still uses
the old flag in at least one location:

third_party/WebKit/Source/WebCore/platform/graphics/filters/skia/FEBlendSkia.cpp:
In function 'SkBlendImageFilter::Mode
WebCore::toSkiaMode(WebCore::BlendModeType)':
third_party/WebKit/Source/WebCore/platform/graphics/filters/skia/FEBlendSkia.cpp:44:
error: 'kMultiply_Mode' is not a member of 'SkBlendImageFilter'

Expand All Messages | Collapse All Messages