Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

Issue 72310044: agent/mongo: Revert attempted use of juju-mongodb

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by gz
Modified:
11 years, 1 month ago
Reviewers:
mp+209959, jameinel, natefinch
Visibility:
Public.

Description

agent/mongo: Revert attempted use of juju-mongodb Currently upstart scripts are generated on the client and included in the cloud-init data. The change to check for the existence of the new juju-mongodb package breaks remote bootstrap, as it will see the alternative location locally with a stat, then generate an upstart file that the spawned machine cannot use. This branch reverts to using a hard coded path where mongod can be found. Future work will cover moving the upstart script generatation off the the client and onto the server so it can actually do the right thing. https://code.launchpad.net/~gz/juju-core/revert_upstart_mongodb_1286279/+merge/209959 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M agent/mongo/mongo.go View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 3
gz
Please take a look.
11 years, 1 month ago (2014-03-07 16:18:53 UTC) #1
jameinel
LGTM, but I don't mind having someone else give it a look.
11 years, 1 month ago (2014-03-07 16:20:42 UTC) #2
natefinch
11 years, 1 month ago (2014-03-07 16:22:54 UTC) #3
On 2014/03/07 16:20:42, jameinel wrote:
> LGTM, but I don't mind having someone else give it a look.

LGTM.  Thanks.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b