Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(122)

Issue 7229061: gm self-tests: add 565 mode testing, in addition to 8888 mode (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by epoger
Modified:
11 years, 5 months ago
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

gm self-tests: add 565 mode testing, in addition to 8888 mode Committed: https://code.google.com/p/skia/source/detail?r=7489

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -17 lines) Patch
M gm/tests/outputs/aaclip-readback/output-expected/command_line View 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/aaclip-readback/output-expected/json-summary.txt View 1 chunk +7 lines, -0 lines 0 comments Download
M gm/tests/outputs/aaclip-write/output-expected/command_line View 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/aaclip-write/output-expected/json-summary.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M gm/tests/outputs/compared-against-different-pixels/output-expected/command_line View 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-different-pixels/output-expected/json-summary.txt View 2 chunks +7 lines, -0 lines 0 comments Download
M gm/tests/outputs/compared-against-empty-dir/output-expected/command_line View 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-empty-dir/output-expected/json-summary.txt View 2 chunks +7 lines, -0 lines 0 comments Download
M gm/tests/outputs/compared-against-empty-dir/output-expected/stdout View 1 chunk +1 line, -0 lines 0 comments Download
M gm/tests/outputs/compared-against-identical-bytes/output-expected/command_line View 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-identical-bytes/output-expected/json-summary.txt View 1 chunk +7 lines, -0 lines 0 comments Download
M gm/tests/outputs/compared-against-identical-pixels/output-expected/command_line View 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-identical-pixels/output-expected/json-summary.txt View 1 chunk +7 lines, -0 lines 0 comments Download
M gm/tests/outputs/no-readpath/output-expected/command_line View 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/no-readpath/output-expected/json-summary.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M gm/tests/run.sh View 1 4 chunks +15 lines, -10 lines 0 comments Download

Messages

Total messages: 10
epoger
I'd like to add 565 testing before moving further with https://codereview.appspot.com/7238043/ ('output max-pixel-err if we're ...
11 years, 5 months ago (2013-01-30 20:06:02 UTC) #1
epoger
+rmistry in CC
11 years, 5 months ago (2013-01-30 20:07:26 UTC) #2
reed1
I am unfamiliar with this area. Can eric or ravi be the reviewer?
11 years, 5 months ago (2013-01-30 20:44:15 UTC) #3
epoger
Sure, one of those guys can be the reviewer... But my question for you, Mike: ...
11 years, 5 months ago (2013-01-30 20:46:23 UTC) #4
reed1
On 2013/01/30 20:46:23, epoger wrote: > Sure, one of those guys can be the reviewer... ...
11 years, 5 months ago (2013-01-30 20:47:09 UTC) #5
robertphillips
gpu?
11 years, 5 months ago (2013-01-30 20:51:22 UTC) #6
EricB
I'm not terribly familiar with this either, but given that it's duplicating the 8888 code, ...
11 years, 5 months ago (2013-01-30 20:55:53 UTC) #7
rmistry
LGTM as well
11 years, 5 months ago (2013-01-30 21:00:02 UTC) #8
epoger
On 2013/01/30 20:51:22, robertphillips wrote: > gpu? As far as I know, when running in ...
11 years, 5 months ago (2013-01-30 21:04:53 UTC) #9
reed1
11 years, 5 months ago (2013-01-30 21:05:32 UTC) #10
On 2013/01/30 21:04:53, epoger wrote:
> On 2013/01/30 20:51:22, robertphillips wrote:
> > gpu?
> 
> As far as I know, when running in gpu modes the bitmap is read back into an
8888
> canvas.  Mike, is that right?

Roger dodger
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b