Do not hash mapping field names of a reserved struct.

Do not hash mapping field names of a reserved struct.

With this fixed, Chrome behaves the same on WebGL conformance tests 1.0.2 with/without --enable-shader-name-hashing

BUG=
TEST=WebGL conformance tests
Committed: https://code.google.com/p/angleproject/source/detail?r=1809

[Zhenyao Mo, 2013-01-26 02:10:59]

I think this is the last standing issue in shader name hashing.

Please have a look.

[kbr1, 2013-01-26 02:49:01]

LGTM if this has been tested, but please correct a typo in the description:
"preserved" -> "reserved"

[Zhenyao Mo, 2013-01-30 18:44:22]

Alok, can you also have a look?

[Alok Priyadarshi, 2013-01-30 21:46:41]

https://codereview.appspot.com/7229043/diff/3001/src/compiler/OutputGLSLBase.cpp
File src/compiler/OutputGLSLBase.cpp (right):

https://codereview.appspot.com/7229043/diff/3001/src/compiler/OutputGLSLBase....
src/compiler/OutputGLSLBase.cpp:270: if (structTypeName !=
"gl_DepthRangeParameters")
It seems a bit flaky and unscalable to compare specific strings. Can we instead
check if the type is in-built?

[Zhenyao Mo, 2013-01-31 18:45:15]

On 2013/01/30 21:46:41, Alok Priyadarshi wrote:
>
https://codereview.appspot.com/7229043/diff/3001/src/compiler/OutputGLSLBase.cpp
> File src/compiler/OutputGLSLBase.cpp (right):
> 
>
https://codereview.appspot.com/7229043/diff/3001/src/compiler/OutputGLSLBase....
> src/compiler/OutputGLSLBase.cpp:270: if (structTypeName !=
> "gl_DepthRangeParameters")
> It seems a bit flaky and unscalable to compare specific strings. Can we
instead
> check if the type is in-built?

Alok: thanks for the advice.  Revised.  Please have another look.

[Alok Priyadarshi, 2013-01-31 18:49:26]

much better! lgtm