Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(455)

Issue 7228078: Change vertex buffer allocator functions to take size rather than layout (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by JimVV
Modified:
11 years, 10 months ago
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Change vertex buffer allocator functions to take size rather than layout. Another step in cleaning up vertex layout code. The point here is to remove any reference to vertex layout from the low-level allocation functions, which only need to know the size of the vertex.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -45 lines) Patch
M src/gpu/GrBufferAllocPool.h View 4 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/GrBufferAllocPool.cpp View 2 chunks +12 lines, -14 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrGpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrGpu.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M src/gpu/GrTextContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
JimVV
11 years, 10 months ago (2013-01-31 19:52:09 UTC) #1
robertphillips
LGTM
11 years, 10 months ago (2013-01-31 19:56:42 UTC) #2
JimVV
11 years, 10 months ago (2013-01-31 20:14:08 UTC) #3
Message was sent while issue was closed.
Committed as r7497.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b