Issue 7228048: Make a bunch of virtuals in GrDrawTarget and GrGpu private. Subclasses shouldn't call them directly.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7228048: Make a bunch of virtuals in GrDrawTarget and GrGpu private. Subclasses shouldn't call them directly. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by bsalomon

Modified:
11 years, 5 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Make a bunch of virtuals in GrDrawTarget and GrGpu private. Subclasses shouldn't call them directly. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=7413

Patch Set 2 : #

Total comments: 5

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -137 lines)			Patch
M	src/gpu/GrDrawTarget.h	View		4 chunks	+41 lines, -59 lines	3 comments	Download
M	src/gpu/GrDrawTarget.cpp	View		1 chunk	+1 line, -1 line	1 comment	Download
M	src/gpu/GrGpu.h	View		3 chunks	+30 lines, -49 lines	0 comments	Download
M	src/gpu/GrGpu.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrInOrderDrawBuffer.h	View		2 chunks	+7 lines, -6 lines	1 comment	Download
M	src/gpu/GrInOrderDrawBuffer.cpp	View	1	3 chunks	+11 lines, -11 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.h	View		3 chunks	+3 lines, -9 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL_program.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

This is some cleanup that I thought best to remove from a substantive change that ...

11 years, 5 months ago (2013-01-28 15:10:14 UTC) #1

robertphillips

LGTM https://codereview.appspot.com/7228048/diff/2001/src/gpu/GrDrawTarget.h File src/gpu/GrDrawTarget.h (right): https://codereview.appspot.com/7228048/diff/2001/src/gpu/GrDrawTarget.h#newcode957 src/gpu/GrDrawTarget.h:957: What's up with this comment?

11 years, 5 months ago (2013-01-28 15:19:54 UTC) #2

bsalomon

11 years, 5 months ago (2013-01-28 15:21:45 UTC) #3

https://codereview.appspot.com/7228048/diff/2001/src/gpu/GrDrawTarget.h
File src/gpu/GrDrawTarget.h (right):

https://codereview.appspot.com/7228048/diff/2001/src/gpu/GrDrawTarget.h#newco...
src/gpu/GrDrawTarget.h:957: 
On 2013/01/28 15:19:54, robertphillips wrote:
> What's up with this comment?

It's a bit unclear. I will update it to say:

"A subclass may override this function if it wishes to be notified when the clip
is changed. The override should call INHERITED::clipWillBeSet()."

Expand All Messages | Collapse All Messages