Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1673)

Issue 7227055: Update filter tool to allow more flexible filtering (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by robertphillips
Modified:
11 years, 5 months ago
Reviewers:
DerekS
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This CL refocuses the filter app on filter (rather than dumping out textures & paths). It leverages the debugger's DrawCommand and DebugCanvas classes to allow more flexible filters to be written. It is intended to allow filter prototyping prior to being folded into SkPictureRecord as a peep-hole. The FontDescriptor was moved from ports to core to allow filter to be compiled without adding an additional dependency. Additionally, FontDescriptor's residence in ports was preventing the addition of a toString method to SkPaint. Ultimately I hope to move this more towards having individual filter objects with check and apply entry points.

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed filter usage message #

Total comments: 8

Patch Set 3 : Added debugger to filter's include directories #

Patch Set 4 : Added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -318 lines) Patch
M debugger/SkDebugCanvas.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M debugger/SkDebugCanvas.cpp View 1 2 5 chunks +10 lines, -11 lines 0 comments Download
M debugger/SkDrawCommand.h View 1 2 3 2 chunks +15 lines, -1 line 0 comments Download
M debugger/SkDrawCommand.cpp View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M gyp/core.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M gyp/ports.gyp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M gyp/tools.gyp View 1 2 1 chunk +8 lines, -1 line 0 comments Download
D src/ports/SkFontDescriptor.h View 1 2 1 chunk +0 lines, -46 lines 0 comments Download
D src/ports/SkFontDescriptor.cpp View 1 2 1 chunk +0 lines, -79 lines 0 comments Download
M tools/filtermain.cpp View 1 2 7 chunks +61 lines, -175 lines 0 comments Download

Messages

Total messages: 5
robertphillips
https://codereview.appspot.com/7227055/diff/1/debugger/SkDebugCanvas.cpp File debugger/SkDebugCanvas.cpp (left): https://codereview.appspot.com/7227055/diff/1/debugger/SkDebugCanvas.cpp#oldcode12 debugger/SkDebugCanvas.cpp:12: #include "SkDevice.h" Since this file is now compiled in ...
11 years, 5 months ago (2013-01-30 17:07:20 UTC) #1
DerekS
https://codereview.appspot.com/7227055/diff/2001/debugger/SkDrawCommand.cpp File debugger/SkDrawCommand.cpp (right): https://codereview.appspot.com/7227055/diff/2001/debugger/SkDrawCommand.cpp#newcode234 debugger/SkDrawCommand.cpp:234: this->fPaint = *paint; why store both? https://codereview.appspot.com/7227055/diff/2001/debugger/SkDrawCommand.h File debugger/SkDrawCommand.h ...
11 years, 5 months ago (2013-01-31 14:56:01 UTC) #2
robertphillips
https://codereview.appspot.com/7227055/diff/2001/debugger/SkDrawCommand.cpp File debugger/SkDrawCommand.cpp (right): https://codereview.appspot.com/7227055/diff/2001/debugger/SkDrawCommand.cpp#newcode234 debugger/SkDrawCommand.cpp:234: this->fPaint = *paint; drawBitmapRect takes a SkPaint*. I could've ...
11 years, 5 months ago (2013-01-31 15:22:47 UTC) #3
DerekS
lgtm
11 years, 5 months ago (2013-01-31 15:39:36 UTC) #4
robertphillips
11 years, 5 months ago (2013-01-31 15:57:02 UTC) #5
Message was sent while issue was closed.
Added comment to better explain DrawBitmapRect's paint handling.

committed as r7492
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b