Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4256)

Issue 7226053: Fix Japanese font issue for devices running JB MR1 and higher. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by DerekS
Modified:
11 years, 9 months ago
Reviewers:
TomH
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Fix Japanese font issue for devices running JB MR1 and higher. Android JB MR1 is using a new format of /system/etc/fallback_fonts.xml. This CL preserves backwards compatibility, while also recognizing the new fallback_fonts.xml format ("lang" attrbiute in <file/>). NOTE: This CL was originally sumbitted for Chrome on Android (m18) Committed: https://code.google.com/p/skia/source/detail?r=7448

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -12 lines) Patch
M src/ports/FontHostConfiguration_android.cpp View 6 chunks +41 lines, -12 lines 0 comments Download

Messages

Total messages: 2
DerekS
11 years, 9 months ago (2013-01-29 15:19:05 UTC) #1
TomH
11 years, 9 months ago (2013-01-29 15:37:12 UTC) #2
gerrit-int isn't cooperating with me right now, but assuming this is the same
patch, LGTM.

Nit: line length > 100 col
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b