Issue 7225077: Add support for libgif-5.x.x, which has changed the API from libgif-4.x.x.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by clay.wood

Modified:
11 years, 5 months ago

Reviewers:
DerekS, reed1

CC:
skia-review_googlegroups.com, rmistry

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Add support for libgif-5.x.x, which has changed the API from libgif-4.x.x.

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -0 lines)			Patch
	M	src/images/SkImageDecoder_libgif.cpp	View	1	4 chunks	+25 lines, -0 lines	0 comments	Download
	M	src/images/SkMovie_gif.cpp	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 6

reed1

Derek, do you know if we need to test this change on Android? I'm fine ...

11 years, 5 months ago (2013-02-01 18:16:26 UTC) #1

DerekS

On 2013/02/01 18:16:26, reed1 wrote: > Derek, do you know if we need to test ...

11 years, 5 months ago (2013-02-01 18:22:13 UTC) #2

clay.wood

Yes please :) On Fri, Feb 1, 2013 at 10:30 AM, <reed@google.com> wrote: > lgtm ...

11 years, 5 months ago (2013-02-01 18:45:44 UTC) #4

clay.wood

11 years, 5 months ago (2013-02-01 19:16:27 UTC) #6

On 2013/02/01 19:06:00, reed1 wrote:
> Committed revision 7523.

Thanks!