Issue 7223061: Whitelist 'setParent' in Google Picker API taming

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7223061: Whitelist 'setParent' in Google Picker API taming (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by ihab.awad

Modified:
13 years, 2 months ago

Reviewers:
Jasvir

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

'setParent' was not whitelisted due to an oversight

Patch Set 2 : Whitelist 'setParent' in Google Picker API taming #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+194 lines, -31 lines)			Patch
M	src/com/google/caja/apitaming/google.picker.policyFactory.js	View	1	5 chunks	+10 lines, -31 lines	0 comments	Download
A	tests/com/google/caja/apitaming/picker/viewSetParent.html	View		1 chunk	+46 lines, -0 lines	0 comments	Download
A	tests/com/google/caja/testParserSpeed.html	View	1	1 chunk	+46 lines, -0 lines	0 comments	Download
A	tests/com/google/caja/testParserSpeed.js	View	1	1 chunk	+92 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Jasvir

Not sure you mean to include the parser speed test in here - it's not ...

13 years, 2 months ago (2013-01-30 21:24:45 UTC) #2

ihab.awad

https://codereview.appspot.com/7223061/diff/1/src/com/google/caja/apitaming/cajaTamingGoogleLoader.js File src/com/google/caja/apitaming/cajaTamingGoogleLoader.js (right): https://codereview.appspot.com/7223061/diff/1/src/com/google/caja/apitaming/cajaTamingGoogleLoader.js#newcode31 src/com/google/caja/apitaming/cajaTamingGoogleLoader.js:31: debugger; On 2013/01/30 21:24:45, Jasvir wrote: > Cruft? Done. ...

13 years, 2 months ago (2013-01-30 22:57:10 UTC) #4

@5246

Expand All Messages | Collapse All Messages