Issue 7223048: Fixing crash in cloning empty SkPicture object

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7223048: Fixing crash in cloning empty SkPicture object (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by junov1

Modified:
11 years, 7 months ago

Reviewers:
junov, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fixing crash in cloning empty SkPicture object BUG=https://code.google.com/p/chromium/issues/detail?id=172062 TEST=Pictures unit test, test_clone_empty Committed: https://code.google.com/p/skia/source/detail?r=7430

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -5 lines)			Patch
	M	src/core/SkPicturePlayback.cpp	View	1	4 chunks	+6 lines, -5 lines	0 comments	Download
	M	tests/PictureTest.cpp	View	1	2 chunks	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

reed1

https://codereview.appspot.com/7223048/diff/1/src/core/SkPicturePlayback.cpp File src/core/SkPicturePlayback.cpp (right): https://codereview.appspot.com/7223048/diff/1/src/core/SkPicturePlayback.cpp#newcode183 src/core/SkPicturePlayback.cpp:183: if (deepCopyInfo) { Can you use SafeCount() here? We ...

11 years, 7 months ago (2013-01-28 20:41:12 UTC) #2

reed1

https://codereview.appspot.com/7223048/diff/1/tests/PictureTest.cpp File tests/PictureTest.cpp (right): https://codereview.appspot.com/7223048/diff/1/tests/PictureTest.cpp#newcode397 tests/PictureTest.cpp:397: // Before the fix, we used to crash accessing ...

11 years, 7 months ago (2013-01-28 20:42:37 UTC) #3

lgtm

Expand All Messages | Collapse All Messages