Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(617)

Issue 7220054: Remove a workaround in gm/xfermodes.cpp (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by Leon
Modified:
11 years, 9 months ago
Reviewers:
TomH, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Remove a workaround in gm/xfermodes.cpp We were performing a deep copy of the pixels in a SkBitmap to work around a bug where drawing an SkBitmap whose pixel memory was set with setPixels to an SkPicture did not preserve the pixel memory. Since the workaround was written, we have fixed the bug in two ways: 1. If setPixels is called with a pointer, we wrap the pixels in an SkPixelRef. 2. Picture recording now makes a deep copy of mutable bitmaps. Also switch to using onOnceBeforeDraw, an existing feature on GM that performs the purpose of the init function. BUG=http://code.google.com/p/skia/issues/detail?id=224 Committed: https://code.google.com/p/skia/source/detail?r=7433

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -17 lines) Patch
M gm/xfermodes.cpp View 3 chunks +9 lines, -17 lines 0 comments Download

Messages

Total messages: 4
Leon
11 years, 9 months ago (2013-01-28 19:43:50 UTC) #1
reed1
Can you say way we're removing it?
11 years, 9 months ago (2013-01-28 19:51:58 UTC) #2
Leon
On 2013/01/28 19:51:58, reed1 wrote: > Can you say way we're removing it? New explanation ...
11 years, 9 months ago (2013-01-28 20:22:37 UTC) #3
reed1
11 years, 9 months ago (2013-01-28 20:38:05 UTC) #4
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b