Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2070)

Issue 7220045: [PDF] Fix multi-level page count calculation. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by Steve VanDeBogart
Modified:
11 years, 10 months ago
Reviewers:
edisonn, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

[PDF] Fix multi-level page count calculation. BUG=1091 Committed: https://code.google.com/p/skia/source/detail?r=7478

Patch Set 1 #

Patch Set 2 : nit #

Total comments: 2

Patch Set 3 : Add comment #

Total comments: 1

Patch Set 4 : Update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M src/pdf/SkPDFPage.cpp View 1 2 3 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 8
Steve VanDeBogart
11 years, 10 months ago (2013-01-25 22:54:41 UTC) #1
reed1
https://codereview.appspot.com/7220045/diff/2001/src/pdf/SkPDFPage.cpp File src/pdf/SkPDFPage.cpp (right): https://codereview.appspot.com/7220045/diff/2001/src/pdf/SkPDFPage.cpp#newcode115 src/pdf/SkPDFPage.cpp:115: newNode->insert(kidsName.get(), kids.get()); The following 3 lines are opaque to ...
11 years, 10 months ago (2013-01-28 14:40:21 UTC) #2
Steve VanDeBogart
https://codereview.appspot.com/7220045/diff/2001/src/pdf/SkPDFPage.cpp File src/pdf/SkPDFPage.cpp (right): https://codereview.appspot.com/7220045/diff/2001/src/pdf/SkPDFPage.cpp#newcode115 src/pdf/SkPDFPage.cpp:115: newNode->insert(kidsName.get(), kids.get()); On 2013/01/28 14:40:21, reed1 wrote: > The ...
11 years, 10 months ago (2013-01-28 22:47:23 UTC) #3
reed1
11 years, 10 months ago (2013-01-29 12:57:13 UTC) #4
edisonn
https://codereview.appspot.com/7220045/diff/7001/src/pdf/SkPDFPage.cpp File src/pdf/SkPDFPage.cpp (right): https://codereview.appspot.com/7220045/diff/7001/src/pdf/SkPDFPage.cpp#newcode116 src/pdf/SkPDFPage.cpp:116: // of the tree the code is at (i.e. ...
11 years, 10 months ago (2013-01-29 13:43:48 UTC) #5
edisonn
BTW, Note to myself mostly, we should make this a parameter and run performance tests ...
11 years, 10 months ago (2013-01-29 13:48:25 UTC) #6
Steve VanDeBogart
On 2013/01/29 13:48:25, edisonn wrote: > BTW, Note to myself mostly, we should make this ...
11 years, 10 months ago (2013-01-29 20:09:49 UTC) #7
edisonn
11 years, 10 months ago (2013-01-30 19:21:14 UTC) #8
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b