Issue 7211043: Include windows.h from one place to ensure that min and max macros are not defined.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7211043: Include windows.h from one place to ensure that min and max macros are not defined. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by apatrick1

Modified:
11 years, 7 months ago

Reviewers:
Zhenyao Mo

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Include windows.h from one place to ensure that min and max macros are not defined. These conflict with the STL functions of the same name. This is to make the standalone ANGLE gyp build work again. Committed: https://code.google.com/p/angleproject/source/detail?r=1725

Patch Set 1 : #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -9 lines)			Patch
M	src/common/debug.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/libEGL/Display.h	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	src/libGLESv2/D3DConstantTable.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libGLESv2/mathutil.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/libGLESv2/utilities.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

apatrick1

I considered putting the other system headers like d3d9.h in system.h as well but I ...

11 years, 7 months ago (2013-01-23 21:01:40 UTC) #1

LGTM

Expand All Messages | Collapse All Messages