Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(503)

Issue 72100043: Update dependency rules for new arch and series

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by curtis
Modified:
10 years, 2 months ago
Reviewers:
mp+209736, natefinch
Visibility:
Public.

Description

Update dependency rules for new arch and series This branch corrects recent dependency changes made by myself. Juju CI failed the unit test runs for trusty+arm64 and precise+amd64. I am both incompetent and naieve. We cannot query apt-cache until after the PPAs are added (for old series) and the cache updated. The golang package is available for arm64, but it doesn't work (why is it there?). The go compiler is now selected by matching the uname arch to a list of arch that golang-go really supports. This rule is easier to read. The rule to select the juju-db is evaluated at the moment apt-get install is called. I was able to eliminate the regex after verifying that apt-cache reports the matching packages in the same order they were passed. It returns a vetted and prioritise list. We care about the first line, and only need the name field. https://code.launchpad.net/~sinzui/juju-core/better-arch-series-deps/+merge/209736 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M Makefile View 3 chunks +3 lines, -9 lines 0 comments Download
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2
curtis
Please take a look.
10 years, 2 months ago (2014-03-06 17:29:47 UTC) #1
natefinch
10 years, 2 months ago (2014-03-06 17:49:05 UTC) #2
On 2014/03/06 17:29:47, curtis wrote:
> Please take a look.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b