Issue 7208043: rename kMultiply_Mode to kModulate_Mode because current implementation does not

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by RikC

Modified:
11 years, 5 months ago

Reviewers:
caryclark1;reed, robertphillips, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

rename kMultiply_Mode to kModulate_Mode because current implementation does not implement multiply blending

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -23 lines)			Patch
M	gm/blend.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gm/modecolorfilters.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gm/xfermodes.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	include/core/SkCanvas.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	include/core/SkXfermode.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	include/effects/SkBlendImageFilter.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	include/effects/SkPorterDuff.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	samplecode/SampleColorFilter.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	samplecode/SampleXfermodesBlur.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkDraw.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkXfermode.cpp	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	src/effects/SkBlendImageFilter.cpp	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/effects/SkPorterDuff.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrSWMaskHelper.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pdf/SkPDFGraphicState.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7

RikC

I dropped the changed version of skia into Chromium and it rebuilt with no problems.

11 years, 5 months ago (2013-01-25 07:35:16 UTC) #1

reed1

lgtm I might add a comment in BlendImageFilter, since what it wants is/will-be the soon-to-be-added ...

11 years, 5 months ago (2013-01-25 13:33:39 UTC) #2

RikC

On 2013/01/25 13:33:39, reed1 wrote: > lgtm > > I might add a comment in ...

11 years, 5 months ago (2013-01-30 19:23:30 UTC) #3

RikC

On 2013/01/30 20:46:19, reed1 wrote: > looks goo. Shall I commit this? yes!

11 years, 5 months ago (2013-01-30 20:59:09 UTC) #5

robertphillips

I re-added kMultiply_Mode (as an alias to kModulate_Mode) to both SkXfermode.h and SkBlendImageFilter.h to get ...

11 years, 5 months ago (2013-01-31 13:53:26 UTC) #6

RikC

11 years, 5 months ago (2013-01-31 17:35:54 UTC) #7

Sorry about that.
I did a clean rebuilt of chromium after making the changes and it worked for me.