Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1066)

Issue 7203050: code review 7203050: archive/tar: provide FileInfo method on Header (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years ago by Donovan
Modified:
8 years, 3 months ago
Reviewers:
golang-dev
CC:
adg
Visibility:
Public.

Description

archive/tar: provide FileInfo method on Header No tests yet, just wanted to confirm whether TestRoundTrip in tar_test.go was the best location? Also wanted to check whether the Mode() logic is correct in common.go? Final question, is it worth creating a tar file to test restoring block devices and sockets? I've never done this and don't know if it is a common usage of tar. Fixes issue 4695.

Patch Set 1 #

Patch Set 2 : diff -r 6206c68b2d29 https://code.google.com/p/go #

Patch Set 3 : diff -r 6206c68b2d29 https://code.google.com/p/go #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M src/pkg/archive/tar/common.go View 1 1 chunk +43 lines, -0 lines 3 comments Download

Messages

Total messages: 5
Donovan
Hello golang-dev@googlegroups.com (cc: adg@golang.org), I'd like you to review this change to https://code.google.com/p/go
9 years ago (2013-01-24 12:05:13 UTC) #1
adg
On 24 January 2013 23:05, <DonovanHide@gmail.com> wrote: > Reviewers: golang-dev_googlegroups.com, > > Message: > Hello ...
9 years ago (2013-01-24 12:11:21 UTC) #2
adg
https://codereview.appspot.com/7203050/diff/3/src/pkg/archive/tar/common.go File src/pkg/archive/tar/common.go (right): https://codereview.appspot.com/7203050/diff/3/src/pkg/archive/tar/common.go#newcode85 src/pkg/archive/tar/common.go:85: func (fi headerFileInfo) Mode() (mode os.FileMode) { put a ...
9 years ago (2013-01-24 12:13:20 UTC) #3
remyoudompheng
R=close This patch is obsoleted by revision de92672228d3 http://code.google.com/p/go/source/detail?r=de92672228d3
8 years, 7 months ago (2013-06-05 03:51:23 UTC) #4
remyoudompheng
8 years, 6 months ago (2013-07-20 21:27:04 UTC) #5

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b