Issue 7202046: Add deferred count to GrResource.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7202046: Add deferred count to GrResource. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by bsalomon

Modified:
11 years, 9 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add deferred count to GrResource. This will be used to determine whether a resource can either be deleted or reinserted in the cache when its ref count reaches zero. Committed: https://code.google.com/p/skia/source/detail?r=7355

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Total comments: 2

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -26 lines)			Patch
M	include/gpu/GrEffect.h	View	1 2	3 chunks	+20 lines, -6 lines	0 comments	Download
M	include/gpu/GrEffectStage.h	View		2 chunks	+7 lines, -6 lines	0 comments	Download
M	include/gpu/GrResource.h	View		2 chunks	+15 lines, -12 lines	2 comments	Download
M	src/gpu/GrResource.cpp	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

robertphillips

LGTM https://codereview.appspot.com/7202046/diff/2001/include/gpu/GrEffect.h File include/gpu/GrEffect.h (right): https://codereview.appspot.com/7202046/diff/2001/include/gpu/GrEffect.h#newcode152 include/gpu/GrEffect.h:152: keeps the effect alive outside of GrEffectRef while ...

11 years, 9 months ago (2013-01-23 21:01:02 UTC) #2

bsalomon

11 years, 9 months ago (2013-01-23 21:37:15 UTC) #3

Message was sent while issue was closed.

https://codereview.appspot.com/7202046/diff/2001/include/gpu/GrEffect.h
File include/gpu/GrEffect.h (right):

https://codereview.appspot.com/7202046/diff/2001/include/gpu/GrEffect.h#newco...
include/gpu/GrEffect.h:152: keeps the effect alive outside of GrEffectRef while
allowing any resources owned by the
On 2013/01/23 21:01:02, robertphillips wrote:
> to -> to be

Done.

https://codereview.appspot.com/7202046/diff/4001/include/gpu/GrResource.h
File include/gpu/GrResource.h (right):

https://codereview.appspot.com/7202046/diff/4001/include/gpu/GrResource.h#new...
include/gpu/GrResource.h:72: void incDeferredRefCount() const {
++fDeferredRefCount; }
On 2013/01/23 21:01:03, robertphillips wrote:
> assert >= 0 in dec?

Done.

Expand All Messages | Collapse All Messages