Issue 7201058: Fix nextRangeU(0, MAX_UINT) div by zero.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7201058: Fix nextRangeU(0, MAX_UINT) div by zero. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by bsalomon

Modified:
11 years, 10 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix nextRangeU(0, MAX_UINT) div by zero. R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=7400

Patch Set 1 #

Patch Set 2 : #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	include/utils/SkRandom.h	View	1	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

reed1

Curious: do you find range = max - min 0 == ~range % (range + ...

11 years, 10 months ago (2013-01-25 19:07:04 UTC) #2

bsalomon

11 years, 10 months ago (2013-01-25 19:17:08 UTC) #3

On 2013/01/25 19:07:04, reed1 wrote:
> Curious: do you find
> 
> range = max - min
> 0 == ~range
> % (range + 1)
> 
> clearer to read than
> 
> range = max - min + 1
> 0 == range
> % range

I dunno, doesn't really matter to me. I suppose the use of the word "range" in
the second version is more accurate.

Expand All Messages | Collapse All Messages