Issue 7201046: Make GrResource know whether 3D objects' lifetimes are managed by Skia or not.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7201046: Make GrResource know whether 3D objects' lifetimes are managed by Skia or not. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by bsalomon

Modified:
11 years, 5 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Make GrResource know whether 3D objects' lifetimes are managed by Skia or not. Committed: https://code.google.com/p/skia/source/detail?r=7348

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -65 lines)			Patch
M	include/gpu/GrRenderTarget.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	include/gpu/GrResource.h	View	1 2	3 chunks	+12 lines, -2 lines	0 comments	Download
M	include/gpu/GrSurface.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	include/gpu/GrTexture.h	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/gpu/GrGeometryBuffer.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/gpu/GrIndexBuffer.h	View		1 chunk	+10 lines, -10 lines	0 comments	Download
M	src/gpu/GrPath.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrResource.cpp	View		2 chunks	+6 lines, -2 lines	0 comments	Download
M	src/gpu/GrStencilBuffer.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/gpu/GrVertexBuffer.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGLIndexBuffer.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLIndexBuffer.cpp	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/gpu/gl/GrGLPath.cpp	View	1	3 chunks	+4 lines, -3 lines	0 comments	Download
M	src/gpu/gl/GrGLRenderTarget.h	View		2 chunks	+1 line, -5 lines	0 comments	Download
M	src/gpu/gl/GrGLRenderTarget.cpp	View		5 chunks	+3 lines, -3 lines	0 comments	Download
M	src/gpu/gl/GrGLStencilBuffer.h	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGLTexture.h	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	src/gpu/gl/GrGLTexture.cpp	View		3 chunks	+3 lines, -4 lines	0 comments	Download
M	src/gpu/gl/GrGLVertexBuffer.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLVertexBuffer.cpp	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View		10 chunks	+14 lines, -10 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages