Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1908)

Issue 7201045: Update Android toolchain to NDK r8d with GCC 4.7 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by DerekS
Modified:
11 years, 10 months ago
Reviewers:
EricB
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Update Android toolchain to NDK r8d with GCC 4.7 Committed: https://code.google.com/p/skia/source/detail?r=7343

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -13 lines) Patch
M gyp/common_conditions.gypi View 3 chunks +4 lines, -13 lines 3 comments Download
M gyp/opts.gyp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6
DerekS
11 years, 10 months ago (2013-01-23 16:19:37 UTC) #1
EricB
https://codereview.appspot.com/7201045/diff/1/gyp/common_conditions.gypi File gyp/common_conditions.gypi (right): https://codereview.appspot.com/7201045/diff/1/gyp/common_conditions.gypi#newcode341 gyp/common_conditions.gypi:341: '-march=armv7-a', This flag is already defined. Should it be ...
11 years, 10 months ago (2013-01-23 16:22:26 UTC) #2
DerekS
https://codereview.appspot.com/7201045/diff/1/gyp/common_conditions.gypi File gyp/common_conditions.gypi (right): https://codereview.appspot.com/7201045/diff/1/gyp/common_conditions.gypi#newcode341 gyp/common_conditions.gypi:341: '-march=armv7-a', On 2013/01/23 16:22:26, EricB wrote: > This flag ...
11 years, 10 months ago (2013-01-23 16:41:59 UTC) #3
EricB
https://codereview.appspot.com/7201045/diff/1/gyp/common_conditions.gypi File gyp/common_conditions.gypi (right): https://codereview.appspot.com/7201045/diff/1/gyp/common_conditions.gypi#newcode341 gyp/common_conditions.gypi:341: '-march=armv7-a', On 2013/01/23 16:41:59, DerekS wrote: > On 2013/01/23 ...
11 years, 10 months ago (2013-01-23 18:20:36 UTC) #4
DerekS
Yes it is intended, based on the following NDK docs... If you want to use ...
11 years, 10 months ago (2013-01-23 18:23:34 UTC) #5
EricB
11 years, 10 months ago (2013-01-23 18:26:56 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b