Modify submit_try to work on windows

Modify submit_try to work on windows
Committed: https://code.google.com/p/skia/source/detail?r=7379

[rmistry, 2013-01-24 21:18:04]

LGTM

[EricB, 2013-01-24 21:21:59]

Accidentally published early.  Patch set 2 is ready.

[rmistry, 2013-01-24 21:23:50]

LGTM

https://codereview.appspot.com/7199053/diff/4001/tools/submit_try
File tools/submit_try (right):

https://codereview.appspot.com/7199053/diff/4001/tools/submit_try#newcode182
tools/submit_try:182: print proc.communicate()[0]
Do we need to print this? if yes then lets put some context around it.

[EricB, 2013-01-24 21:27:24]

https://codereview.appspot.com/7199053/diff/4001/tools/submit_try
File tools/submit_try (right):

https://codereview.appspot.com/7199053/diff/4001/tools/submit_try#newcode182
tools/submit_try:182: print proc.communicate()[0]
On 2013/01/24 21:23:50, rmistry wrote:
> Do we need to print this? if yes then lets put some context around it.

It's just the output from "gcl try".  For example:

D:\google\skia1\trunk>python tools\submit_try whitespace --bot Skia_iOS_Debug_32

WARNING:root:Didn't find codereview.settings
Results will be emailed to: borenet@google.com
Patch 'whitespace' sent to try server: Skia_iOS_Debug_32_Trybot

I think it's nice to have it there, and it's what the user would expect if
they've used "gcl try" before.

[rmistry, 2013-01-24 21:31:34]

https://codereview.appspot.com/7199053/diff/4001/tools/submit_try
File tools/submit_try (right):

https://codereview.appspot.com/7199053/diff/4001/tools/submit_try#newcode182
tools/submit_try:182: print proc.communicate()[0]
On 2013/01/24 21:27:24, EricB wrote:
> On 2013/01/24 21:23:50, rmistry wrote:
> > Do we need to print this? if yes then lets put some context around it.
> 
> It's just the output from "gcl try".  For example:
> 
> D:\google\skia1\trunk>python tools\submit_try whitespace --bot
Skia_iOS_Debug_32
> 
> WARNING:root:Didn't find codereview.settings
> Results will be emailed to: mailto:borenet@google.com
> Patch 'whitespace' sent to try server: Skia_iOS_Debug_32_Trybot
> 
> I think it's nice to have it there, and it's what the user would expect if
> they've used "gcl try" before.

What I meant is it would be useful to have another print stmt before it, for
example print ' '.join(try_args) or does the cmd get printed before the output
the way it is?

[EricB, 2013-01-24 21:33:48]

https://codereview.appspot.com/7199053/diff/4001/tools/submit_try
File tools/submit_try (right):

https://codereview.appspot.com/7199053/diff/4001/tools/submit_try#newcode182
tools/submit_try:182: print proc.communicate()[0]
On 2013/01/24 21:31:35, rmistry wrote:
> On 2013/01/24 21:27:24, EricB wrote:
> > On 2013/01/24 21:23:50, rmistry wrote:
> > > Do we need to print this? if yes then lets put some context around it.
> > 
> > It's just the output from "gcl try".  For example:
> > 
> > D:\google\skia1\trunk>python tools\submit_try whitespace --bot
> Skia_iOS_Debug_32
> > 
> > WARNING:root:Didn't find codereview.settings
> > Results will be emailed to: mailto:borenet@google.com
> > Patch 'whitespace' sent to try server: Skia_iOS_Debug_32_Trybot
> > 
> > I think it's nice to have it there, and it's what the user would expect if
> > they've used "gcl try" before.
> 
> What I meant is it would be useful to have another print stmt before it, for
> example print ' '.join(try_args) or does the cmd get printed before the output
> the way it is?

Oh. Currently the command does not get printed out. I can do that if you'd like.

[rmistry, 2013-01-24 21:35:39]

https://codereview.appspot.com/7199053/diff/4001/tools/submit_try
File tools/submit_try (right):

https://codereview.appspot.com/7199053/diff/4001/tools/submit_try#newcode182
tools/submit_try:182: print proc.communicate()[0]
On 2013/01/24 21:33:48, EricB wrote:
> On 2013/01/24 21:31:35, rmistry wrote:
> > On 2013/01/24 21:27:24, EricB wrote:
> > > On 2013/01/24 21:23:50, rmistry wrote:
> > > > Do we need to print this? if yes then lets put some context around it.
> > > 
> > > It's just the output from "gcl try".  For example:
> > > 
> > > D:\google\skia1\trunk>python tools\submit_try whitespace --bot
> > Skia_iOS_Debug_32
> > > 
> > > WARNING:root:Didn't find codereview.settings
> > > Results will be emailed to: mailto:borenet@google.com
> > > Patch 'whitespace' sent to try server: Skia_iOS_Debug_32_Trybot
> > > 
> > > I think it's nice to have it there, and it's what the user would expect if
> > > they've used "gcl try" before.
> > 
> > What I meant is it would be useful to have another print stmt before it, for
> > example print ' '.join(try_args) or does the cmd get printed before the
output
> > the way it is?
> 
> Oh. Currently the command does not get printed out. I can do that if you'd
like.

It may be useful, but leaving it upto you.

[EricB, 2013-01-24 21:39:00]

Uploaded patch set 3 and committed as r7379.

https://codereview.appspot.com/7199053/diff/4001/tools/submit_try
File tools/submit_try (right):

https://codereview.appspot.com/7199053/diff/4001/tools/submit_try#newcode182
tools/submit_try:182: print proc.communicate()[0]
On 2013/01/24 21:35:39, rmistry wrote:
> On 2013/01/24 21:33:48, EricB wrote:
> > On 2013/01/24 21:31:35, rmistry wrote:
> > > On 2013/01/24 21:27:24, EricB wrote:
> > > > On 2013/01/24 21:23:50, rmistry wrote:
> > > > > Do we need to print this? if yes then lets put some context around it.
> > > > 
> > > > It's just the output from "gcl try".  For example:
> > > > 
> > > > D:\google\skia1\trunk>python tools\submit_try whitespace --bot
> > > Skia_iOS_Debug_32
> > > > 
> > > > WARNING:root:Didn't find codereview.settings
> > > > Results will be emailed to: mailto:borenet@google.com
> > > > Patch 'whitespace' sent to try server: Skia_iOS_Debug_32_Trybot
> > > > 
> > > > I think it's nice to have it there, and it's what the user would expect
if
> > > > they've used "gcl try" before.
> > > 
> > > What I meant is it would be useful to have another print stmt before it,
for
> > > example print ' '.join(try_args) or does the cmd get printed before the
> output
> > > the way it is?
> > 
> > Oh. Currently the command does not get printed out. I can do that if you'd
> like.
> 
> It may be useful, but leaving it upto you.

I added it. It makes what the wrapper script is doing less opaque.