Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1987)

Issue 7198049: Make all GrContext members that return a texture also ref the texture for the caller. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by bsalomon
Modified:
11 years, 9 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Make all GrContext members that return a texture also ref the texture for the caller. Committed: https://code.google.com/p/skia/source/detail?r=7362

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -113 lines) Patch
M include/gpu/GrContext.h View 1 2 3 8 chunks +26 lines, -20 lines 0 comments Download
M include/gpu/SkGr.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkBitmapProcShader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkBlendImageFilter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/effects/SkSingleInputImageFilter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrAtlas.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/GrContext.cpp View 8 chunks +30 lines, -33 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 4 chunks +9 lines, -14 lines 0 comments Download
M src/gpu/SkGr.cpp View 6 chunks +10 lines, -14 lines 0 comments Download
M src/gpu/effects/GrTextureStripAtlas.cpp View 3 chunks +1 line, -3 lines 0 comments Download
M tests/ClipCacheTest.cpp View 4 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 4
bsalomon
This makes the current code safer. It also will allow the cache to drop its ...
11 years, 9 months ago (2013-01-24 14:30:32 UTC) #1
robertphillips
LGTM https://codereview.appspot.com/7198049/diff/3001/tests/ClipCacheTest.cpp File tests/ClipCacheTest.cpp (right): https://codereview.appspot.com/7198049/diff/3001/tests/ClipCacheTest.cpp#newcode158 tests/ClipCacheTest.cpp:158: REPORTER_ASSERT(reporter, texture1->getRefCnt()); They are left over from an ...
11 years, 9 months ago (2013-01-24 14:45:43 UTC) #2
robertphillips
Does the instance count at exit on the gm's remain the same?
11 years, 9 months ago (2013-01-24 14:46:42 UTC) #3
bsalomon
11 years, 9 months ago (2013-01-24 14:47:56 UTC) #4
Message was sent while issue was closed.
On 2013/01/24 14:46:42, robertphillips wrote:
> Does the instance count at exit on the gm's remain the same?

I that checked bench, tests, and gm don't leak GrResources according to the
instance counter.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b