Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3695)

Issue 7197054: Changed optimization level to D3DCOMPILE_OPTIMIZATION_LEVEL1. With (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by kbr1
Modified:
11 years, 3 months ago
Reviewers:
apatrick1
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Changed optimization level to D3DCOMPILE_OPTIMIZATION_LEVEL1. With this optimization level, it appears that array index clamping can be enabled on Windows without destabilizing WebGL content. Tested this change with array index clamping enabled with MapsGL, a previous failing test from AlteredQualia, many Three.js demos, the Julia Set tutorial from acko.net, the WebGL 1.0.1 conformance suite, and other content; all worked. BUG=none Committed: https://code.google.com/p/angleproject/source/detail?r=1734

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/build_angle.gypi View 1 chunk +1 line, -1 line 0 comments Download
M src/common/version.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
kbr1
11 years, 3 months ago (2013-01-25 00:30:05 UTC) #1
apatrick1
11 years, 3 months ago (2013-01-25 00:34:04 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b