Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(898)

Issue 7196046: Move code in isPaintOpaque from SkDeferredCanvas.cpp to SkPaint (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by junov1
Modified:
11 years, 8 months ago
Reviewers:
junov, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Move code in isPaintOpaque from SkDeferredCanvas.cpp to SkPaintPriv The purpose of this code move is to make it re-usable in order to implement occlusion culling optimizations in SkPicture similar to what we have now in SkDeferredCanvas. BUG=https://code.google.com/p/chromium/issues/detail?id=164530 Committed: https://code.google.com/p/skia/source/detail?r=7361

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -70 lines) Patch
M gyp/core.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M gyp/utils.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
A src/core/SkPaintPriv.h View 1 1 chunk +18 lines, -0 lines 1 comment Download
A src/core/SkPaintPriv.cpp View 1 1 chunk +78 lines, -0 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 1 3 chunks +2 lines, -70 lines 0 comments Download

Messages

Total messages: 7
junov
PTAL
11 years, 8 months ago (2013-01-23 20:33:15 UTC) #1
reed1
Lets move it into a private .h file for now (similar to our SkTSort.h or ...
11 years, 8 months ago (2013-01-23 20:50:41 UTC) #2
junov1
Right now, code in src/utils can only include the public headers from the skia core, ...
11 years, 8 months ago (2013-01-23 21:03:34 UTC) #3
reed1
We should change that (it would seem). If we are supporting the features in utils ...
11 years, 8 months ago (2013-01-23 21:05:57 UTC) #4
junov
Patch
11 years, 8 months ago (2013-01-23 21:42:49 UTC) #5
reed1
lgtm
11 years, 8 months ago (2013-01-23 22:12:26 UTC) #6
reed1
11 years, 8 months ago (2013-01-23 22:12:50 UTC) #7
https://codereview.appspot.com/7196046/diff/4001/src/core/SkPaintPriv.h
File src/core/SkPaintPriv.h (right):

https://codereview.appspot.com/7196046/diff/4001/src/core/SkPaintPriv.h#newco...
src/core/SkPaintPriv.h:15: 
// What happened to my nice dox comment?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b