Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1039)

Issue 7194051: Incorporated patch from haixia@ changing the default implementation of (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by kbr1
Modified:
11 years, 10 months ago
Reviewers:
dgkoch, apatrick1
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Incorporated patch from haixia@ changing the default implementation of array index clamping to use the clamp intrinsic. This works more reliably on pure OpenGL ES devices and on Windows. Added a mechanism in ShBuiltInResources to choose the strategy for array index clamping. BUG=none TEST=various out-of-bounds array indexing tests and various WebGL content Committed: https://code.google.com/p/angleproject/source/detail?r=1733

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -22 lines) Patch
M include/GLSLANG/ShaderLang.h View 1 2 3 2 chunks +16 lines, -1 line 0 comments Download
M src/common/version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/Compiler.cpp View 1 2 3 chunks +12 lines, -4 lines 0 comments Download
M src/compiler/OutputESSL.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/OutputESSL.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/OutputGLSL.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/OutputGLSL.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/OutputGLSLBase.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/OutputGLSLBase.cpp View 1 2 3 chunks +13 lines, -2 lines 0 comments Download
M src/compiler/ShHandle.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/ShaderLang.cpp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/TranslatorESSL.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/TranslatorGLSL.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/third_party/compiler/ArrayBoundsClamper.h View 1 2 2 chunks +8 lines, -3 lines 0 comments Download
M src/third_party/compiler/ArrayBoundsClamper.cpp View 1 2 2 chunks +16 lines, -7 lines 0 comments Download

Messages

Total messages: 5
kbr1
11 years, 10 months ago (2013-01-24 23:56:19 UTC) #1
apatrick1
LGTM
11 years, 10 months ago (2013-01-24 23:59:39 UTC) #2
dgkoch
Is a CLA required for this (has that been covered)?
11 years, 10 months ago (2013-01-25 14:13:13 UTC) #3
kbr1
No, hshi@ is a Google employee. (Got his address wrong in the CL description, sorry.)
11 years, 10 months ago (2013-01-25 18:23:44 UTC) #4
dgkoch
11 years, 10 months ago (2013-01-25 18:55:35 UTC) #5
Message was sent while issue was closed.
Ok great. Wasn't sure if he was or not.  Thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b