Issue 7190043: Added multi-select deletion to debugger

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7190043: Added multi-select deletion to debugger (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by robertphillips

Modified:
11 years, 8 months ago

Reviewers:
DerekS

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

The prior single-selection mechanism for deleting commands was painful to use for trimming an skp down to only a few commands. This change allows deletion to operate on multiple commands at once.

Patch Set 1 #

Total comments: 2

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -10 lines)			Patch
	M	debugger/QT/SkDebuggerGUI.cpp	View		2 chunks	+19 lines, -10 lines	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

DerekS

lgtm with one question https://codereview.appspot.com/7190043/diff/1/debugger/QT/SkDebuggerGUI.cpp File debugger/QT/SkDebuggerGUI.cpp (right): https://codereview.appspot.com/7190043/diff/1/debugger/QT/SkDebuggerGUI.cpp#newcode467 debugger/QT/SkDebuggerGUI.cpp:467: fSkipCommands[row] = false; so if ...

11 years, 8 months ago (2013-01-22 18:55:45 UTC) #2

robertphillips

https://codereview.appspot.com/7190043/diff/1/debugger/QT/SkDebuggerGUI.cpp File debugger/QT/SkDebuggerGUI.cpp (right): https://codereview.appspot.com/7190043/diff/1/debugger/QT/SkDebuggerGUI.cpp#newcode467 debugger/QT/SkDebuggerGUI.cpp:467: fSkipCommands[row] = false; Lines 456-458 should limit the operation ...

11 years, 8 months ago (2013-01-22 19:01:05 UTC) #3

Message was sent while issue was closed.

committed as r7318

Expand All Messages | Collapse All Messages