Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1990)

Issue 7188046: Switch GrEffect::onIsEqual signature back to GrEffect from GrEffectRef. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by bsalomon
Modified:
11 years, 3 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Switch GrEffect::onIsEqual signature back to GrEffect from GrEffectRef. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=7326

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -39 lines) Patch
M include/gpu/GrEffect.h View 4 chunks +6 lines, -5 lines 1 comment Download
M src/effects/SkBicubicImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkBlendImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkMatrixConvolutionImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrTextureDomainEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrTextureDomainEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
bsalomon
All the changes outside of GrEffect.h are just removing "Ref" from every subclass's onIsEqual signature ...
11 years, 3 months ago (2013-01-22 20:30:49 UTC) #1
robertphillips
11 years, 3 months ago (2013-01-22 20:34:02 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b