Issue 7187047: Fix bug in 1xN SkBitmapProcShader optimization

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7187047: Fix bug in 1xN SkBitmapProcShader optimization (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by robertphillips

Modified:
11 years, 5 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

When the matrix is non-trivial (i.e., not just a translate or identity), the setup code helpfully scales by the inverse of the width and height (in SkBitmapProcState::chooseProcs). S32_D32_constX_shaderproc must compensate for this when there is a complex matrix but no filtering.

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -17 lines)			Patch
	M	bench/TileBench.cpp	View		5 chunks	+22 lines, -16 lines	0 comments	Download
	M	src/core/SkBitmapProcState.cpp	View		2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

reed1

lets add a big juicy comment, tying these changes to the unit-inverse logic in setup. ...

11 years, 5 months ago (2013-01-22 20:18:55 UTC) #2

Message was sent while issue was closed.

Added comment

committed as r7325

Expand All Messages | Collapse All Messages