Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(35)

Delta Between Two Patch Sets: lily/trill-spanner-engraver.cc

Issue 7185044: Caches the interior skylines of vertical axis groups and systems. Base URL: http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Left Patch Set: Responses to David's review. Created 12 years, 1 month ago
Right Patch Set: Gives Hairpin outside-staff-interface Created 11 years, 11 months ago
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
Right: Side by side diff | Download
LEFTRIGHT
(no file at all)
1 /* 1 /*
2 This file is part of LilyPond, the GNU music typesetter. 2 This file is part of LilyPond, the GNU music typesetter.
3 3
4 Copyright (C) 2000--2012 Jan Nieuwenhuizen <janneke@gnu.org> 4 Copyright (C) 2000--2012 Jan Nieuwenhuizen <janneke@gnu.org>
5 5
6 LilyPond is free software: you can redistribute it and/or modify 6 LilyPond is free software: you can redistribute it and/or modify
7 it under the terms of the GNU General Public License as published by 7 it under the terms of the GNU General Public License as published by
8 the Free Software Foundation, either version 3 of the License, or 8 the Free Software Foundation, either version 3 of the License, or
9 (at your option) any later version. 9 (at your option) any later version.
10 10
(...skipping 10 matching lines...) Expand all
21 C&P from text-spanner.cc 21 C&P from text-spanner.cc
22 22
23 - todo: ending should be detected automatically? a new note 23 - todo: ending should be detected automatically? a new note
24 automatically is the end of the trill? 24 automatically is the end of the trill?
25 */ 25 */
26 26
27 #include "engraver.hh" 27 #include "engraver.hh"
28 28
29 #include "international.hh" 29 #include "international.hh"
30 #include "note-column.hh" 30 #include "note-column.hh"
31 #include "outside-staff-interface.hh"
31 #include "pointer-group-interface.hh" 32 #include "pointer-group-interface.hh"
32 #include "side-position-interface.hh" 33 #include "side-position-interface.hh"
33 #include "stream-event.hh" 34 #include "stream-event.hh"
34 #include "spanner.hh" 35 #include "spanner.hh"
35 36
36 #include "translator.icc" 37 #include "translator.icc"
37 38
38 class Trill_spanner_engraver : public Engraver 39 class Trill_spanner_engraver : public Engraver
39 { 40 {
40 public: 41 public:
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 announce_end_grob (finished_, ender->self_scm ()); 105 announce_end_grob (finished_, ender->self_scm ());
105 span_ = 0; 106 span_ = 0;
106 current_event_ = 0; 107 current_event_ = 0;
107 } 108 }
108 109
109 if (event_drul_[START]) 110 if (event_drul_[START])
110 { 111 {
111 current_event_ = event_drul_[START]; 112 current_event_ = event_drul_[START];
112 span_ = make_spanner ("TrillSpanner", event_drul_[START]->self_scm ()); 113 span_ = make_spanner ("TrillSpanner", event_drul_[START]->self_scm ());
113 Side_position_interface::set_axis (span_, Y_AXIS); 114 Side_position_interface::set_axis (span_, Y_AXIS);
115 Outside_staff_interface::chain_y_offset_callback (span_);
114 } 116 }
115 } 117 }
116 118
117 void 119 void
118 Trill_spanner_engraver::typeset_all () 120 Trill_spanner_engraver::typeset_all ()
119 { 121 {
120 if (finished_) 122 if (finished_)
121 { 123 {
122 if (!finished_->get_bound (RIGHT)) 124 if (!finished_->get_bound (RIGHT))
123 { 125 {
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 /* create */ 163 /* create */
162 "TrillSpanner ", 164 "TrillSpanner ",
163 165
164 /* read */ 166 /* read */
165 "currentCommandColumn " 167 "currentCommandColumn "
166 "currentMusicalColumn ", 168 "currentMusicalColumn ",
167 169
168 /* write */ 170 /* write */
169 "" 171 ""
170 ); 172 );
LEFTRIGHT

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b