Issue 7181049: Add GrDrawState::DeferredState for saving GrDrawStates in GrInOrderDrawBuffer.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7181049: Add GrDrawState::DeferredState for saving GrDrawStates in GrInOrderDrawBuffer. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by bsalomon

Modified:
11 years, 9 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add GrDrawState::DeferredState for saving GrDrawStates in GrInOrderDrawBuffer. A future CL will do the unref'ing of GrResources when converting a GrDrawState to a DeferredState. Committed: https://code.google.com/p/skia/source/detail?r=7342

Patch Set 1 #

Patch Set 2 : #

Total comments: 5

Patch Set 3 : #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+265 lines, -157 lines)			Patch
M	include/gpu/GrEffect.h	View	1 2	5 chunks	+24 lines, -15 lines	0 comments	Download
M	include/gpu/GrEffectStage.h	View	1 2	2 chunks	+57 lines, -1 line	0 comments	Download
M	src/gpu/GrDrawState.h	View	1 2	25 chunks	+172 lines, -120 lines	0 comments	Download
M	src/gpu/GrInOrderDrawBuffer.h	View	1 2	2 chunks	+5 lines, -7 lines	0 comments	Download
M	src/gpu/GrInOrderDrawBuffer.cpp	View	1 2	5 chunks	+7 lines, -14 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bsalomon

Feel free to suggest better names for the classes I've added. :)

11 years, 9 months ago (2013-01-22 21:03:42 UTC) #1

robertphillips

lgtm + some questions https://codereview.appspot.com/7181049/diff/2001/include/gpu/GrEffectStage.h File include/gpu/GrEffectStage.h (right): https://codereview.appspot.com/7181049/diff/2001/include/gpu/GrEffectStage.h#newcode114 include/gpu/GrEffectStage.h:114: saveTo? https://codereview.appspot.com/7181049/diff/2001/include/gpu/GrEffectStage.h#newcode124 include/gpu/GrEffectStage.h:124: restoreFrom? https://codereview.appspot.com/7181049/diff/2001/src/gpu/GrDrawState.h ...

11 years, 9 months ago (2013-01-23 14:03:36 UTC) #2

bsalomon

I liked the suggestion to move the save/restore functions to the deferred objects. I did ...

11 years, 9 months ago (2013-01-23 15:27:10 UTC) #3

LGTM

Expand All Messages | Collapse All Messages