Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(122)

Issue 7181048: Fix saving modified skp from debugger (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by robertphillips
Modified:
11 years, 5 months ago
Reviewers:
DerekS
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This appears to work. In the old approach the deletion of the existing 'fPicture' also freed all the SkPaints (and other objects) that the 'fDebugCanvas' relied on. I believe this was so that the debugger would automatically "switch" to the modified skp. The current approach doesn't do this but it also doesn't crash.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M debugger/QT/SkDebuggerGUI.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download
M debugger/SkDebugger.h View 1 1 chunk +1 line, -1 line 0 comments Download
M debugger/SkDebugger.cpp View 1 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 6
robertphillips
11 years, 5 months ago (2013-01-22 16:02:46 UTC) #1
robertphillips
This should address http://code.google.com/p/skia/issues/detail?id=998
11 years, 5 months ago (2013-01-22 16:04:27 UTC) #2
DerekS
https://codereview.appspot.com/7181048/diff/1/debugger/SkDebugger.cpp File debugger/SkDebugger.cpp (right): https://codereview.appspot.com/7181048/diff/1/debugger/SkDebugger.cpp#newcode38 debugger/SkDebugger.cpp:38: SkPicture* newPicture = new SkPicture; can we just clone ...
11 years, 5 months ago (2013-01-22 16:44:27 UTC) #3
robertphillips
https://codereview.appspot.com/7181048/diff/1/debugger/SkDebugger.cpp File debugger/SkDebugger.cpp (right): https://codereview.appspot.com/7181048/diff/1/debugger/SkDebugger.cpp#newcode38 debugger/SkDebugger.cpp:38: SkPicture* newPicture = new SkPicture; Unfortunately that doesn't respect ...
11 years, 5 months ago (2013-01-22 17:52:43 UTC) #4
DerekS
lgtm
11 years, 5 months ago (2013-01-22 17:56:18 UTC) #5
robertphillips
11 years, 5 months ago (2013-01-22 18:04:41 UTC) #6
Message was sent while issue was closed.
I added a comment to explain why clone isn't called in copyPicture.

committed as r7314
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b